Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kibana filters bug #452

Merged
merged 25 commits into from
May 15, 2018
Merged

Fix Kibana filters bug #452

merged 25 commits into from
May 15, 2018

Conversation

jesusgn90
Copy link
Contributor

@jesusgn90 jesusgn90 commented May 15, 2018

Hello team, this pull request fixes #451

Brief summary:

  • Added new class to build queries from base query
  • Removed rison dependency since it's no longer needed
  • The filter management is being done on controllers instead the Discover directive
  • Now we are emitting specific events whenever we are fetching data or communicating to the Discover directive
  • The number of useless requests to fetch data has been reduced
  • The synchronization actions are working as expected regardless the amount of data and/or the amount of the machine resources
  • Added factories to store shared information between services and/or controllers, leaving the root scope ligther
  • Removing useless listeners whose could cause wrong situations

Best regards,
Jesús

@jesusgn90 jesusgn90 self-assigned this May 15, 2018
@jesusgn90 jesusgn90 mentioned this pull request May 15, 2018
@jesusgn90 jesusgn90 force-pushed the 3.2-fix-filters-2 branch 2 times, most recently from d6a9cf6 to 8385f38 Compare May 15, 2018 09:30
@havidarou
Copy link
Member

LGTM! Faster!

@havidarou havidarou merged commit e50f286 into 3.2 May 15, 2018
@havidarou havidarou deleted the 3.2-fix-filters-2 branch May 15, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants