Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test feature: generate a report from an agent #4629

Merged
merged 12 commits into from
Oct 12, 2022

Conversation

Mayons95
Copy link
Contributor

@Mayons95 Mayons95 commented Sep 29, 2022

Description

Hi team, this PR includes a new test case to validate the report generation from any module choosing a particular agent.
This validation will increase the testing coverage on all modules.

Issues Resolved

#4627

Evidence

Test it's working for WZD and Kibana

image

Test comments:

The errors during the test execution are not related to this PR.
It's a bug previously detected and reported on: #4621

@Mayons95 Mayons95 added automation automation type/test Test issue labels Sep 29, 2022
@Mayons95 Mayons95 self-assigned this Sep 29, 2022
@Mayons95 Mayons95 marked this pull request as draft September 29, 2022 19:34
@AlexRuiz7 AlexRuiz7 changed the title Feature/generate a report from a agent Add test feature: generate a report from an agent Oct 4, 2022
@Mayons95 Mayons95 marked this pull request as ready for review October 4, 2022 20:02
@Mayons95 Mayons95 requested a review from a team as a code owner October 4, 2022 20:02
@Mayons95 Mayons95 marked this pull request as draft October 4, 2022 20:02
@Mayons95 Mayons95 marked this pull request as ready for review October 4, 2022 20:50
Copy link
Contributor

@mauceballos mauceballos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, see the comments thx.

@@ -0,0 +1,16 @@
import { Then } from 'cypress-cucumber-preprocessor/steps';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name of the file "the-user-agent-report-is-displayed-in-the-table-when.js"
should be
"the-user-agent-report-is-displayed-in-the-table-then.js"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done !

Signed-off-by: Facundo Mayon <mayonf95@gmail.com>
Signed-off-by: Facundo Mayon <mayonf95@gmail.com>
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 7.18% ( 2608 / 36300 )
Branches 3.02% ( 846 / 27973 )
Functions 5.02% ( 444 / 8852 )
Lines 7.26% ( 2523 / 34748 )

@Mayons95 Mayons95 merged commit 31c6a9d into 4.4-7.10 Oct 12, 2022
@Mayons95 Mayons95 deleted the feature/generate-a-report-from-a-agent branch October 12, 2022 12:56
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

github-actions bot pushed a commit that referenced this pull request Oct 18, 2022
* Add pages and functionallity

* Add feature changes

* Try to capture text

* Add report name compare with agent id

* Add a validation for modules with no data

* Add time to refresh button status

* Add validation

* Add last changes

* Adding pages

* Rename agent-report-displayed-file

* Add sign to commit

Signed-off-by: Facundo Mayon <mayonf95@gmail.com>

* Add git signature

Signed-off-by: Facundo Mayon <mayonf95@gmail.com>

Signed-off-by: Facundo Mayon <mayonf95@gmail.com>
(cherry picked from commit 31c6a9d)
@github-actions

This comment was marked as outdated.

AlexRuiz7 pushed a commit that referenced this pull request Oct 18, 2022
…#4707)

Add test feature: generate a report from an agent (#4629)

* Add pages and functionallity

* Add feature changes

* Try to capture text

* Add report name compare with agent id

* Add a validation for modules with no data

* Add time to refresh button status

* Add validation

* Add last changes

* Adding pages

* Rename agent-report-displayed-file

* Add sign to commit

Signed-off-by: Facundo Mayon <mayonf95@gmail.com>

* Add git signature

Signed-off-by: Facundo Mayon <mayonf95@gmail.com>

Signed-off-by: Facundo Mayon <mayonf95@gmail.com>
(cherry picked from commit 31c6a9d)

Co-authored-by: Mayons95 <104914131+Mayons95@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Oct 18, 2022
* Add pages and functionallity

* Add feature changes

* Try to capture text

* Add report name compare with agent id

* Add a validation for modules with no data

* Add time to refresh button status

* Add validation

* Add last changes

* Adding pages

* Rename agent-report-displayed-file

* Add sign to commit

Signed-off-by: Facundo Mayon <mayonf95@gmail.com>

* Add git signature

Signed-off-by: Facundo Mayon <mayonf95@gmail.com>

Signed-off-by: Facundo Mayon <mayonf95@gmail.com>
(cherry picked from commit 31c6a9d)
AlexRuiz7 pushed a commit that referenced this pull request Oct 18, 2022
…ent (#4708)

Add test feature: generate a report from an agent (#4629)

* Add pages and functionallity

* Add feature changes

* Try to capture text

* Add report name compare with agent id

* Add a validation for modules with no data

* Add time to refresh button status

* Add validation

* Add last changes

* Adding pages

* Rename agent-report-displayed-file

* Add sign to commit

Signed-off-by: Facundo Mayon <mayonf95@gmail.com>

* Add git signature

Signed-off-by: Facundo Mayon <mayonf95@gmail.com>

Signed-off-by: Facundo Mayon <mayonf95@gmail.com>
(cherry picked from commit 31c6a9d)

Co-authored-by: Mayons95 <104914131+Mayons95@users.noreply.github.com>
AlexRuiz7 pushed a commit that referenced this pull request Apr 25, 2023
* Add pages and functionallity

* Add feature changes

* Try to capture text

* Add report name compare with agent id

* Add a validation for modules with no data

* Add time to refresh button status

* Add validation

* Add last changes

* Adding pages

* Rename agent-report-displayed-file

* Add sign to commit

Signed-off-by: Facundo Mayon <mayonf95@gmail.com>

* Add git signature

Signed-off-by: Facundo Mayon <mayonf95@gmail.com>

Signed-off-by: Facundo Mayon <mayonf95@gmail.com>
(cherry picked from commit 31c6a9d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation automation type/test Test issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automation - WZD - Feature - Generate a module report from a particular agent
4 participants