Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature rules are displayed when user clicks the first page - WZD #4663

Conversation

mauceballos
Copy link
Contributor

@mauceballos mauceballos commented Oct 11, 2022

Description

Added a Feature to increase coverage for the Rule module. This feature checks the paginator on the rules page.

Evidence

test execution

2022-10-11_12-33

Check List

  • All tests pass
  • New functionality includes testing.
  • New functionality has been documented.

@mauceballos mauceballos requested a review from a team as a code owner October 11, 2022 15:36
@mauceballos mauceballos linked an issue Oct 11, 2022 that may be closed by this pull request
@mauceballos mauceballos changed the title 4648 wzd feature rules are displayed when user clicks the first page Add feature rules are displayed when user clicks the first page - wzd - 4648 Oct 11, 2022
Copy link
Contributor

@Mayons95 Mayons95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved a few of grammatical errors.

LGTM!

@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 7.18% ( 2608 / 36300 )
Branches 3.02% ( 846 / 27973 )
Functions 5.02% ( 444 / 8852 )
Lines 7.26% ( 2523 / 34748 )

1 similar comment
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 7.18% ( 2608 / 36300 )
Branches 3.02% ( 846 / 27973 )
Functions 5.02% ( 444 / 8852 )
Lines 7.26% ( 2523 / 34748 )

@AlexRuiz7 AlexRuiz7 merged commit 7dfe4d6 into 4.4-7.10 Oct 13, 2022
@AlexRuiz7 AlexRuiz7 deleted the 4648-wzd-feature-rules-are-displayed-when-user-clicks-the-first-page branch October 13, 2022 09:31
github-actions bot pushed a commit that referenced this pull request Oct 13, 2022
… - 4648 (#4663)

* draft commit for evidence

* draft commit for evidencie

* add validate paginator on Rule page feature

* fix for some issue

* Update draft--check-rows-dropdow.feature

* Update the-user-see-that-the-rule-list-is-paginated.then.js

* Update the-page-button-disable.then.js

* Update the-first-page-is-displayed-then.js

* Update a-new-set-of-rules-displayed.when.js

* Update validate-paginator.feature

* Update draft--check-rows-dropdow.feature

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 7dfe4d6)
github-actions bot pushed a commit that referenced this pull request Oct 13, 2022
… - 4648 (#4663)

* draft commit for evidence

* draft commit for evidencie

* add validate paginator on Rule page feature

* fix for some issue

* Update draft--check-rows-dropdow.feature

* Update the-user-see-that-the-rule-list-is-paginated.then.js

* Update the-page-button-disable.then.js

* Update the-first-page-is-displayed-then.js

* Update a-new-set-of-rules-displayed.when.js

* Update validate-paginator.feature

* Update draft--check-rows-dropdow.feature

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 7dfe4d6)
AlexRuiz7 pushed a commit that referenced this pull request Oct 13, 2022
…the first page - wzd - 4648 (#4667)

Add feature rules are displayed when user clicks the first page - wzd - 4648  (#4663)

* draft commit for evidence

* draft commit for evidencie

* add validate paginator on Rule page feature

* fix for some issue

* Update draft--check-rows-dropdow.feature

* Update the-user-see-that-the-rule-list-is-paginated.then.js

* Update the-page-button-disable.then.js

* Update the-first-page-is-displayed-then.js

* Update a-new-set-of-rules-displayed.when.js

* Update validate-paginator.feature

* Update draft--check-rows-dropdow.feature

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 7dfe4d6)

Co-authored-by: mauceballos <76791841+mauceballos@users.noreply.github.com>
AlexRuiz7 pushed a commit that referenced this pull request Oct 13, 2022
…ks the first page - wzd - 4648 (#4668)

Add feature rules are displayed when user clicks the first page - wzd - 4648  (#4663)

* draft commit for evidence

* draft commit for evidencie

* add validate paginator on Rule page feature

* fix for some issue

* Update draft--check-rows-dropdow.feature

* Update the-user-see-that-the-rule-list-is-paginated.then.js

* Update the-page-button-disable.then.js

* Update the-first-page-is-displayed-then.js

* Update a-new-set-of-rules-displayed.when.js

* Update validate-paginator.feature

* Update draft--check-rows-dropdow.feature

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 7dfe4d6)

Co-authored-by: mauceballos <76791841+mauceballos@users.noreply.github.com>
@AlexRuiz7
Copy link
Member

AlexRuiz7 commented Oct 13, 2022

The file test/cypress/cypress/integration/features/management/rules/draft--check-rows-dropdow.feature was added to this pull request by mistake and must be removed.

Solved in #4673

@mauceballos
Copy link
Contributor Author

Some Features are failing because misspellings on step features

solved #4682

@AlexRuiz7 AlexRuiz7 changed the title Add feature rules are displayed when user clicks the first page - wzd - 4648 Add feature rules are displayed when user clicks the first page - WZD Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation automation type/test Test issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WZD - Feature - Validate paginator on Rule page
3 participants