Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an environment validation to check the request #4738

Merged

Conversation

Mayons95
Copy link
Contributor

Hello team, we create this PR to integrate functionality that checks the environment where the test suite execution it's been executing.
This functionality fixes some problems that we have with the previous test suite execution.

image

@Mayons95 Mayons95 requested a review from a team as a code owner October 20, 2022 18:39
@Mayons95 Mayons95 linked an issue Oct 20, 2022 that may be closed by this pull request
@@ -1,4 +1,5 @@
import { Given } from 'cypress-cucumber-preprocessor/steps';
import { head } from 'fetch-mock';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, delete this line.

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 7.38% ( 2677 / 36280 )
Branches 3.19% ( 891 / 27958 )
Functions 5.13% ( 454 / 8845 )
Lines 7.47% ( 2593 / 34732 )

Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexRuiz7 AlexRuiz7 changed the title Adding a environment validation to check the request Add an environment validation to check the request Oct 21, 2022
@mauceballos mauceballos merged commit 4ff3b8c into 4.4-7.10 Oct 21, 2022
@mauceballos mauceballos deleted the feature/4736-add-sample-data-feature-multi-environment branch October 21, 2022 11:53
github-actions bot pushed a commit that referenced this pull request Oct 21, 2022
* Adding a environment validation to check the request

* Deleting dependency

(cherry picked from commit 4ff3b8c)
github-actions bot pushed a commit that referenced this pull request Oct 21, 2022
* Adding a environment validation to check the request

* Deleting dependency

(cherry picked from commit 4ff3b8c)
Mayons95 added a commit that referenced this pull request Oct 21, 2022
#4741)

Adding a environment validation to check the request (#4738)

* Adding a environment validation to check the request

* Deleting dependency

(cherry picked from commit 4ff3b8c)

Co-authored-by: Mayons95 <104914131+Mayons95@users.noreply.github.com>
Mayons95 added a commit that referenced this pull request Oct 21, 2022
…uest (#4742)

Adding a environment validation to check the request (#4738)

* Adding a environment validation to check the request

* Deleting dependency

(cherry picked from commit 4ff3b8c)

Co-authored-by: Mayons95 <104914131+Mayons95@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sample Data Feature - Multi-environment
3 participants