Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/GitHub action for multi env #4744

Closed
wants to merge 46 commits into from

Conversation

Mayons95
Copy link
Contributor

Hello team, this PR is created to fix problems whit github actions

Desvelao and others added 30 commits September 13, 2022 08:08
Create the plugin setting schema
Define the current plugin settings
Remove refactored code
Use dynamically the definition of the plugin settings
Add new hooks to manage when a input value or form has changed
Add new inputs components
Refactor Header, BottomBar, Configuration components
Remove deprecated files
Changed the endpoint that updating the plugin setting to support
  multiple settings at the same time
Refactor the getConfiguration service. Split the logic to:
  - Read the file and transform to JSON
  - Obfuscate the password key of the host configuration
…ion of the plugin settings in default configuration file and UI
…st changes

- Rename plugin setting properties:
  - `default` to `defaultValue`
  - `defaultHidden` to `defaultValueIfNotSet`
  - `configurableFile` to `isConfigurableFromFile`
  - configurableUI` to `isConfigurableFromUI`
  - `requireHealthCheck` to `requiresRunningHealthCheck`
  - `requireReload` to `requiresReloadingBrowserTab`
  - `requireRestart` to `requiresRestartingPluginPlatform`
- Fix tests
@Mayons95 Mayons95 requested a review from a team as a code owner October 21, 2022 16:15
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 7.65% ( 2780 / 36360 )
Branches 3.41% ( 954 / 28003 )
Functions 5.78% ( 517 / 8937 )
Lines 7.72% ( 2685 / 34800 )

@Mayons95 Mayons95 marked this pull request as draft October 21, 2022 18:07
@Mayons95 Mayons95 linked an issue Oct 21, 2022 that may be closed by this pull request
3 tasks
@Mayons95 Mayons95 closed this Oct 21, 2022
@Mayons95 Mayons95 deleted the fix/github-action-for-multi-env branch October 21, 2022 19:42
@Mayons95 Mayons95 removed a link to an issue Oct 21, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants