-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deployment wizard to add the WAZUH_PROTOCOL
variable only for UDP connections
#4760
Conversation
…into 4318-variable-of-deployment-wazuh-protocol
@@ -221,8 +221,19 @@ export const RegisterAgent = withErrorBoundary( | |||
async getRemoteInfo() { | |||
try { | |||
const result = await WzRequest.apiReq('GET', '/agents/000/config/request/remote', {}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: If I am not wrong, this request gets the data of the master
node. Related to this pull request #4737 that adds the selection of the manager to connect, the protocol should use the configurated by the selected manager.
For another hand, what should be the value of the protocol variable for the next situation (taking into account the mentioned pull request):
- manager1: tcp, udp
- manager2: udp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment in the linked issue to tread this topic: #4318 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: ☑️ with comments
Test: ✅
WAZUH_PROTOCOL
variable only for UDP connections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Superseded by #4776 |
Description
Now, the
WAZUH_PROTOCOL
variable is only displayed if a remote connection is of type secure and its protocol is UDP.Notice
Issues Resolved
#4318
Evidence
Connection: Secure Protocol: UDP :
udpsecure.mp4
Connection: Secure Protocol: TCP :
TCPSECURE.mp4
Connection: Syslog
syslogtcpnosecure.mp4
Error handling and warning in the UI to the client.
error.mp4
Test
*Go to the Agents' tab
*Click on the 'Deploy new agent' button
*Verify that when a connection is type secure and its protocol is UDP, the variable WAZUH_PROTOCOL appears in the installation command, otherwise it does not appear.
You can use this data to test with the imposter:
CASE 1: Variable
WAZUH_PROTOCOL
should appear in the installation command.Case 2: WAZUH_PROTOCOL variable should not appear in the install command