Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix after login #4770

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Fix after login #4770

merged 2 commits into from
Oct 28, 2022

Conversation

mauceballos
Copy link
Contributor

Description

This PR fixes the close session after login in on WZD.
When We run the test suite on the GitHub Actions for WZD all test cases fail on the
Given The wazuh admin user is logged
step.

the problem is an if a condition that redirects the URL using
navigate('/');

Issues Resolved

#4745

Evidence

![2022-10-27_14-12](https://user-images.githubusercontent.com/76791841/198356758-9d61bf55-ff78-4614-9dec-ddc9d0cc3f05.png)

##Error

add-agent-from-deploy-new-agent.feature.mp4

Test

[Provide instructions to test this PR]

Check List

  • All tests pass
  • New functionality includes testing.
  • New functionality has been documented.

@mauceballos mauceballos requested a review from a team as a code owner October 27, 2022 17:29
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 7.93% ( 2897 / 36516 )
Branches 3.57% ( 1005 / 28112 )
Functions 6.8% ( 615 / 9038 )
Lines 7.99% ( 2792 / 34947 )

@mauceballos mauceballos mentioned this pull request Oct 27, 2022
Closed
3 tasks
@AlexRuiz7 AlexRuiz7 marked this pull request as draft October 28, 2022 12:30
@AlexRuiz7 AlexRuiz7 linked an issue Oct 28, 2022 that may be closed by this pull request
Github actions -automated test suite #4745
Closed
3 tasks
@Mayons95 Mayons95 assigned Mayons95 and mauceballos and unassigned Mayons95 Oct 28, 2022
@Mayons95 Mayons95 marked this pull request as ready for review October 28, 2022 18:02
@Mayons95 Mayons95 merged commit a1c79e4 into 4.4-7.10 Oct 28, 2022
@Mayons95 Mayons95 deleted the fix-after-login branch October 28, 2022 18:02
@github-actions github-actions bot mentioned this pull request Oct 28, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Oct 28, 2022
@mauceballos @github-actions
Fix after login (#4770)
889cd0d 
* fix after login

* fix close session after login success

(cherry picked from commit a1c79e4)
@github-actions github-actions bot mentioned this pull request Oct 28, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Oct 28, 2022
@mauceballos @github-actions
Fix after login (#4770)
8514e88 
* fix after login

* fix close session after login success

(cherry picked from commit a1c79e4)
Mayons95 pushed a commit that referenced this pull request Oct 28, 2022
@github-actions @mauceballos
[Backport 4.4-2.3-wzd] Fix after login (#4778)
5eb3cba 
Fix after login (#4770)

* fix after login

* fix close session after login success

(cherry picked from commit a1c79e4)

Co-authored-by: mauceballos <76791841+mauceballos@users.noreply.github.com>
Mayons95 pushed a commit that referenced this pull request Oct 31, 2022
@github-actions @mauceballos
[Backport 4.4-7.16] Fix after login (#4777)
ef329a4 
Fix after login (#4770)

* fix after login

* fix close session after login success

(cherry picked from commit a1c79e4)

Co-authored-by: mauceballos <76791841+mauceballos@users.noreply.github.com>
@Desvelao Desvelao mentioned this pull request Dec 20, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mayons95 Mayons95 Mayons95 approved these changes

Assignees

@mauceballos mauceballos

Labels
automation automation type/test Test issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github actions -automated test suite
2 participants
@mauceballos @Mayons95