Fix logout from Wazuh when SAML is enabled (4.3) #4815

Tostti · 2022-11-07T14:22:24Z

Description

When SAML is enabled, the logout button inside the Wazuh plugin didn't work properly. That was because there is a function to remove the token before redirecting to logout, and the logout URL is different when SAML is enabled.

The solucion provided is to get the logout URL programatically from the logout anchor. That way, the issue is resolved and there is no need to modify anything in case that the logout URL changes in the future.

Issues Resolved

#4595

Evidence

Trying to log out from the Wazuh plugin before the changes:

Trying to log out from the Wazuh plugin after the changes (the user is correctly redirected to the idp login page):

Test

Scenario: have an environment with xPack
When the user opens the Wazuh plugin and clicks on log out
Then the session should be closed and the user redirected to the login page

Scenario: have an environment with OpenDistro
When the user opens the Wazuh plugin and clicks on log out
Then the session should be closed and the user redirected to the login page

Scenario: have an environment with OpenSearch
When the user opens the Wazuh plugin and clicks on log out
Then the session should be closed and the user redirected to the login page

Scenario: have an environment with SAML
When the user opens the Wazuh plugin and clicks on log out
Then the session should be closed and the user redirected to the login page

Check List

All tests pass
- yarn test:jest
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

github-actions · 2022-11-07T14:38:01Z

Jest Test Coverage	%	values
Statements	6.89%	( 2513 / 36483 )
Branches	2.72%	( 769 / 28224 )
Functions	4.6%	( 410 / 8920 )
Lines	6.97%	( 2432 / 34906 )

Mayons95

LGTM

* change function to get the path programatically * update changelog (cherry picked from commit 72ba21a)

…4820) change function to get the path programatically (#4815) * change function to get the path programatically * update changelog (cherry picked from commit 72ba21a) Co-authored-by: Nico Guevara <42900763+Tostti@users.noreply.github.com>

#4821) change function to get the path programatically (#4815) * change function to get the path programatically * update changelog (cherry picked from commit 72ba21a) Co-authored-by: Nico Guevara <42900763+Tostti@users.noreply.github.com>

chantal-kelm · 2022-11-10T18:38:55Z

Opensearch with SAML

saml.mp4

* [Backport 4.3-7.10] Create pull_request_template.md (#4591) Create pull_request_template.md (#4583) (cherry picked from commit aac7f22) Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> * Bump 4.3.9 (#4655) * bump: Version v4.3.9-7.10.2 * bump: Version v4.3.9-7.10.2 * change function to get the path programatically (#4815) * change function to get the path programatically * update changelog * Add support for Wazuh 4.3.10 - 7.10.2 (#4839) Bump 4.3.10 * Fixed 4.3.10 changelog (#4845) Fixed changelog Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> Co-authored-by: Nico Guevara <42900763+Tostti@users.noreply.github.com>

* [Backport 4.3-7.10] Create pull_request_template.md (#4591) Create pull_request_template.md (#4583) (cherry picked from commit aac7f22) Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> * Bump 4.3.9 (#4655) * bump: Version v4.3.9-7.10.2 * bump: Version v4.3.9-7.10.2 * change function to get the path programatically (#4815) * change function to get the path programatically * update changelog * Add support for Wazuh 4.3.10 - 7.10.2 (#4839) Bump 4.3.10 * Fixed 4.3.10 changelog (#4845) Fixed changelog Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> Co-authored-by: Nico Guevara <42900763+Tostti@users.noreply.github.com> (cherry picked from commit d0c9e91)

Post-release v4.3.10 (#4879) * [Backport 4.3-7.10] Create pull_request_template.md (#4591) Create pull_request_template.md (#4583) (cherry picked from commit aac7f22) Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> * Bump 4.3.9 (#4655) * bump: Version v4.3.9-7.10.2 * bump: Version v4.3.9-7.10.2 * change function to get the path programatically (#4815) * change function to get the path programatically * update changelog * Add support for Wazuh 4.3.10 - 7.10.2 (#4839) Bump 4.3.10 * Fixed 4.3.10 changelog (#4845) Fixed changelog Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> Co-authored-by: Nico Guevara <42900763+Tostti@users.noreply.github.com> (cherry picked from commit d0c9e91) Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>

* [Backport 4.3-7.10] Create pull_request_template.md (#4591) Create pull_request_template.md (#4583) (cherry picked from commit aac7f22) Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> * Bump 4.3.9 (#4655) * bump: Version v4.3.9-7.10.2 * bump: Version v4.3.9-7.10.2 * change function to get the path programatically (#4815) * change function to get the path programatically * update changelog * Add support for Wazuh 4.3.10 - 7.10.2 (#4839) Bump 4.3.10 * Fixed 4.3.10 changelog (#4845) Fixed changelog Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> Co-authored-by: Nico Guevara <42900763+Tostti@users.noreply.github.com> (cherry picked from commit d0c9e91)

Post-release v4.3.10 (#4879) * [Backport 4.3-7.10] Create pull_request_template.md (#4591) Create pull_request_template.md (#4583) (cherry picked from commit aac7f22) Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> * Bump 4.3.9 (#4655) * bump: Version v4.3.9-7.10.2 * bump: Version v4.3.9-7.10.2 * change function to get the path programatically (#4815) * change function to get the path programatically * update changelog * Add support for Wazuh 4.3.10 - 7.10.2 (#4839) Bump 4.3.10 * Fixed 4.3.10 changelog (#4845) Fixed changelog Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> Co-authored-by: Nico Guevara <42900763+Tostti@users.noreply.github.com> (cherry picked from commit d0c9e91)

change function to get the path programatically

decad1a

Tostti self-assigned this Nov 7, 2022

Tostti added backport 4.3-7.16 labels Nov 7, 2022

Tostti linked an issue Nov 7, 2022 that may be closed by this pull request

SAML logout error "not found" #4779

Closed

1 task

Tostti removed a link to an issue Nov 7, 2022

SAML logout error "not found" #4779

Closed

1 task

Tostti linked an issue Nov 7, 2022 that may be closed by this pull request

SAML logout error "not found" #4779

Closed

1 task

update changelog

25ac3bb

Tostti marked this pull request as ready for review November 7, 2022 14:35

Tostti requested a review from a team November 7, 2022 15:24

Mayons95 approved these changes Nov 7, 2022

View reviewed changes

chantal-kelm self-requested a review November 7, 2022 18:15

chantal-kelm approved these changes Nov 7, 2022

View reviewed changes

Tostti merged commit 72ba21a into 4.3-7.10 Nov 7, 2022

Tostti deleted the fix/wazuh-plugin-logout-button-path-4.3 branch November 7, 2022 19:29

github-actions bot mentioned this pull request Nov 7, 2022

[Backport 4.3-7.16] change function to get the path programatically #4820

Merged

github-actions bot pushed a commit that referenced this pull request Nov 7, 2022

change function to get the path programatically (#4815)

4defa10

* change function to get the path programatically * update changelog (cherry picked from commit 72ba21a)

github-actions bot mentioned this pull request Nov 7, 2022

[Backport 4.3-1.2-wzd] change function to get the path programatically #4821

Merged

github-actions bot pushed a commit that referenced this pull request Nov 7, 2022

change function to get the path programatically (#4815)

6a6124f

* change function to get the path programatically * update changelog (cherry picked from commit 72ba21a)

AlexRuiz7 changed the title ~~change function to get the path programatically~~ Change function to get the path programmatically Nov 9, 2022

AlexRuiz7 changed the title ~~Change function to get the path programmatically~~ Fix logout from Wazuh when SAML is enabled (4.3) Nov 9, 2022

Tostti mentioned this pull request Nov 11, 2022

Add warning to last step wazuh/wazuh-documentation#5752

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix logout from Wazuh when SAML is enabled (4.3) #4815

Fix logout from Wazuh when SAML is enabled (4.3) #4815

Tostti commented Nov 7, 2022 •

edited

Loading

github-actions bot commented Nov 7, 2022

Mayons95 left a comment

chantal-kelm commented Nov 10, 2022

Fix logout from Wazuh when SAML is enabled (4.3) #4815

Fix logout from Wazuh when SAML is enabled (4.3) #4815

Conversation

Tostti commented Nov 7, 2022 • edited Loading

Description

Issues Resolved

Evidence

Test

Check List

github-actions bot commented Nov 7, 2022

Mayons95 left a comment

Choose a reason for hiding this comment

chantal-kelm commented Nov 10, 2022

Tostti commented Nov 7, 2022 •

edited

Loading