-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 4.4-7.16] Add cluster's IP and protocol as suggestions in the agent deployment wizard [Backport 4.4-7.16] #4862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wizard (#4776) * section deploy new agent in progress * tabSystemD and tabSysV * section deploy a new agent done * cleaning code * cleaning code * test * CHANGELOG * code cleaning * design for when a user selects an obsolete system version * code cleanup * changed macOS for macOS and updated the macOS version view * development with information update provided by ci cd * applying some of the new changes that the ci cd team sent us today * delete * updating information sent by ci/cd on operating systems, commands, etc. * logic of displaying message to rare operating systems and redirecting them to documentation * logic of displaying message to rare operating systems and redirecting them to documentation * wazuh protocol variable * Ordered OS buttons in deploy new agent steps * Replaced input server address * Testing signed commits * Added server address component isolated from register-agent component * Added test for multiple nodes rendered in combobox * Added wazuh manager multiple ips in command definition * Refactored and cleaned code * Added unit test * Updated CHANGELOG * Added default option and paste only name in combo tag * variable of deployment wazuh protocol * merge 4.4-7.10 * Added free option enter and cleaned code * removing spaces, css den deshuso, unify uppercase * Refactored code and added new tests and fixed old tests * removing link space * fixed labels * Resolved review comments following dev style guide * change of logic in links * Added OS delimiter condition * Added and updated unit tests * Resolved review comments * Removed empty file * Removed snapshot to fix unit tests workflow * message + error handling * Detached getRemoteInfo request in service to ease unit testing * Add agent name to the deployment command (#4739) * Add variable for the agent's name * input is cleaned if there is no data * design input name * Update CHANGELOG * Resolved review comment, unused code and code format Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com> * Fixing tests * Testing signed commit with updated email * Fixing unverified commit * Fixing eslint errors * Added get remote info by node and unit tests * Added server address and protocol behavior * Updated Server address unit tests * Updated and added register agent service unit tests * Added error managment in register agent and server address component * Updated CHANGELOG * Fixed tests workflow * CHANGELOG * udpProtocol:false * constants for repeated text Co-authored-by: chantal.kelm <chantal.belen.kelm@gmail.com> Co-authored-by: Chantal Belén kelm <99441266+chantal-kelm@users.noreply.github.com> Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit d178752)
AlexRuiz7
changed the title
Add cluster's IP and protocol as suggestions in the agent deployment …
[Backport 4.4-27.16] Add cluster's IP and protocol as suggestions in the agent deployment wizard
Nov 14, 2022
AlexRuiz7
changed the title
[Backport 4.4-27.16] Add cluster's IP and protocol as suggestions in the agent deployment wizard
[Backport 4.4-7.16] Add cluster's IP and protocol as suggestions in the agent deployment wizard
Nov 14, 2022
|
Mayons95
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Machi3mfl
changed the title
[Backport 4.4-7.16] Add cluster's IP and protocol as suggestions in the agent deployment wizard
[Backport 4.4-7.16] Fixed WAZUH_PROTOCOL param suggestion
Nov 14, 2022
Machi3mfl
changed the title
[Backport 4.4-7.16] Fixed WAZUH_PROTOCOL param suggestion
[Backport 4.4-7.16] Add cluster's IP and protocol as suggestions in the agent deployment wizard [Backport 4.4-7.16]
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport d178752 from #4776