Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 4.4-2.4-wzd] Fix deploy new agent section #4974

Closed
wants to merge 42 commits into from
Closed

[Backport 4.4-2.4-wzd] Fix deploy new agent section #4974

wants to merge 42 commits into from

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Dec 7, 2022 •
edited
Loading

Description

  • Fixed the way macOS versions and architectures were displayed.
  • Fixed the way agents were displayed.
  • Fixed the way Ubuntu versions were displayed.
  • Added extra steps message and new command for Windows XP and Windows Server 2008
  • Added Alpine agent with all its steps.
  • Windows command fixed
  • CI/CD has updated all installation commands, we have also updated them in our code.

Main PR

#4931

Issues Resolved

#4931

Evidence

Grabacion.de.pantalla.2022-11-30.a.la.s.10.46.16.mov

Steps to test

  • Click on agents
  • Click on deploy new agent
  • Check that the information shown is correct.
  • Check that the information shown for the windows agent is the one shown in this comment
  • Check that the information shown for the alpine agent is the same as the one shown in this comment

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm requested a review from a team as a code owner December 7, 2022 15:37
@chantal-kelm chantal-kelm mentioned this pull request Dec 7, 2022
Merged
6 tasks
@chantal-kelm chantal-kelm changed the title Backport 4933 to 4.4 2.3 wzd [Backport 4.4-2.3-wzd] Fix deploy new agent section Dec 12, 2022
@chantal-kelm chantal-kelm linked an issue Dec 12, 2022 that may be closed by this pull request
Fix section deploy new agent, add alpine agent #4931
Closed
@chantal-kelm chantal-kelm changed the title [Backport 4.4-2.3-wzd] Fix deploy new agent section [Backport 4.4-2.3-wzd] Fixed deploy new agent section Dec 14, 2022
@chantal-kelm chantal-kelm changed the title [Backport 4.4-2.3-wzd] Fixed deploy new agent section [Backport 4.4-2.4-wzd] Fixed deploy new agent section Dec 14, 2022
@chantal-kelm chantal-kelm changed the title [Backport 4.4-2.4-wzd] Fixed deploy new agent section [Backport 4.4-2.4-wzd] Fix deploy new agent section Dec 14, 2022
Mayons95
Mayons95 previously approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@Mayons95 Mayons95 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TR: ✔️

image

Mayons95
Mayons95 previously approved these changes Dec 19, 2022
View reviewed changes
yenienserrano
yenienserrano previously approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chantal-kelm chantal-kelm marked this pull request as draft December 19, 2022 18:45
chantal-kelm and others added 12 commits December 21, 2022 13:28
@chantal-kelm
Fix the agent installation command for macOS (#4968)
269c3d2 
* Fixed the agent installation command for macOS

* CHANGELOG

* Update CHANGELOG.md
@chantal-kelm
Fix agent deployment instructions for HP-UX and Solaris (#4943)
cdf05aa 
* removing auto-deploy variables in hp and solaris

* hide wazuh server address sections, assign group and assign name to agent when os is hp or solaris

* update hp command

* removing auto-deploy variables in alpine

* move message additional installation steps

* links and messages os

* changelog
@chantal-kelm
red hat, centos and windows commands fixed
edcf126
@chantal-kelm
Deploy new agent section: change the commands for all os
7e38a16
@chantal-kelm
Deploy new agent section: change commands for all os
ae55568
@chantal-kelm
clean code
884107f
@chantal-kelm
update commands
ad03103
@chantal-kelm
Deploy new agents: Update commands
fc83f3f
@chantal-kelm
Deploy new agents: Update commands
4e7dd1c
@chantal-kelm
Merge branch '4.4-2.4-wzd' into backport-4933-to-4.4-2.3-wzd
cdfe572
@chantal-kelm
update commnads
dc47606
@chantal-kelm
Merge branch 'backport-4933-to-4.4-2.3-wzd' of https://github.com/waz…
ff396c9 
…uh/wazuh-kibana-app into backport-4933-to-4.4-2.3-wzd
@chantal-kelm chantal-kelm marked this pull request as ready for review December 21, 2022 17:09
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.7% ( 3216 / 36949 )
Branches 4.58% ( 1315 / 28685 )
Functions 7.54% ( 691 / 9156 )
Lines 8.76% ( 3103 / 35383 )

asteriscos
asteriscos approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

Tested it checking the scripts mentioned in this issue

image

@chantal-kelm chantal-kelm removed a link to an issue Dec 22, 2022
Fix section deploy new agent, add alpine agent #4931
Closed
@chantal-kelm chantal-kelm deleted the backport-4933-to-4.4-2.3-wzd branch December 22, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@Mayons95 Mayons95 Mayons95 left review comments

@yenienserrano yenienserrano yenienserrano left review comments

Assignees

@chantal-kelm chantal-kelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chantal-kelm @asteriscos @yenienserrano @Mayons95 @AlexRuiz7