-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicated buttons in SCA inventory #5010
Remove duplicated buttons in SCA inventory #5010
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-5010-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 442c45a65746156a96ea980e46b8148ba4470983
# Push it to GitHub
git push --set-upstream origin backport-5010-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.10 4.4-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.10
# Create a new branch
git switch --create backport-5010-to-4.4-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 442c45a65746156a96ea980e46b8148ba4470983
# Push it to GitHub
git push --set-upstream origin backport-5010-to-4.4-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.10 Then, create a pull request where the |
* fix: remove unused buttons in sca inventory * changelog: add pull request entry to the changelog (cherry picked from commit 442c45a)
* fix: remove unused buttons in sca inventory * changelog: add pull request entry to the changelog (cherry picked from commit 442c45a)
Description
This pull request removes unneeded buttons in the SCA inventory section.
The affected buttons are:
that were displayed on the top of the panel.
With the work in a previous pull request (#4653), these actions are included in the reusable component, but the previous buttons were not removed so they were duplicated.
Issues Resolved
Closes #5011
Evidence
The buttons were placed in the highlighted section.
Test
Scenario 1:
Export formatted
button should not be duplicatedGiven data related to Security configuration assessment scan
When When the user goes to
Modules/Security configuration assessment
And Select a policy
Then the button should be duplicated. It should appear above the table.
Scenario 2:
Refresh
button should not be duplicatedGiven data related to Security configuration assessment scan
When When the user goes to
Modules/Security configuration assessment
And Select a policy
Then the button should be duplicated. It should appear above the table.
Check List
yarn test:jest