Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated buttons in SCA inventory #5010

Merged
merged 3 commits into from
Dec 20, 2022

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Dec 19, 2022

Description

This pull request removes unneeded buttons in the SCA inventory section.

The affected buttons are:

  • Export formatted
  • Refresh

that were displayed on the top of the panel.

With the work in a previous pull request (#4653), these actions are included in the reusable component, but the previous buttons were not removed so they were duplicated.

Issues Resolved

Closes #5011

Evidence

The buttons were placed in the highlighted section.
image

Test

Scenario 1: Export formatted button should not be duplicated
Given data related to Security configuration assessment scan
When When the user goes to Modules/Security configuration assessment
And Select a policy
Then the button should be duplicated. It should appear above the table.

Scenario 2: Refresh button should not be duplicated
Given data related to Security configuration assessment scan
When When the user goes to Modules/Security configuration assessment
And Select a policy
Then the button should be duplicated. It should appear above the table.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao requested a review from a team as a code owner December 19, 2022 14:13
@Desvelao Desvelao self-assigned this Dec 19, 2022
@Desvelao Desvelao added the UI/UX Generic label for things related to the font-end side label Dec 19, 2022
@Desvelao Desvelao changed the title Remove unneeded buttons in SCA inventory Remove duplicated buttons in SCA inventory Dec 19, 2022
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.65% ( 3195 / 36905 )
Branches 4.43% ( 1271 / 28633 )
Functions 7.54% ( 691 / 9155 )
Lines 8.72% ( 3082 / 35336 )

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

Evidence

image

@Desvelao Desvelao merged commit 442c45a into 4.4-2.4-wzd Dec 20, 2022
@Desvelao Desvelao deleted the fix/remove-unused-buttons-sca-inventory-module branch December 20, 2022 10:55
@github-actions
Copy link
Contributor

The backport to 4.4-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-5010-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 442c45a65746156a96ea980e46b8148ba4470983
# Push it to GitHub
git push --set-upstream origin backport-5010-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16

Then, create a pull request where the base branch is 4.4-7.16 and the compare/head branch is backport-5010-to-4.4-7.16.

@github-actions
Copy link
Contributor

The backport to 4.4-7.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.10 4.4-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.10
# Create a new branch
git switch --create backport-5010-to-4.4-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 442c45a65746156a96ea980e46b8148ba4470983
# Push it to GitHub
git push --set-upstream origin backport-5010-to-4.4-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.10

Then, create a pull request where the base branch is 4.4-7.10 and the compare/head branch is backport-5010-to-4.4-7.10.

Desvelao added a commit that referenced this pull request Dec 20, 2022
* fix: remove unused buttons in sca inventory

* changelog: add pull request entry to the changelog

(cherry picked from commit 442c45a)
Desvelao added a commit that referenced this pull request Dec 20, 2022
* fix: remove unused buttons in sca inventory

* changelog: add pull request entry to the changelog

(cherry picked from commit 442c45a)
Desvelao added a commit that referenced this pull request Dec 20, 2022
Remove duplicated buttons in SCA inventory (#5010)

* fix: remove unused buttons in sca inventory

* changelog: add pull request entry to the changelog

(cherry picked from commit 442c45a)
asteriscos pushed a commit that referenced this pull request Dec 20, 2022
Remove duplicated buttons in SCA inventory (#5010)

* fix: remove unused buttons in sca inventory

* changelog: add pull request entry to the changelog

(cherry picked from commit 442c45a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX Generic label for things related to the font-end side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated Export formatted and Refresh buttons in SCA inventory
2 participants