Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 4.4-2.4-wzd] Add validation to agent name #5023

Merged
merged 3 commits into from
Dec 21, 2022
Merged

[Backport 4.4-2.4-wzd] Add validation to agent name #5023

merged 3 commits into from
Dec 21, 2022

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Dec 20, 2022

Backport from #5021

@Tostti
Copy link
Member Author

Tostti commented Dec 20, 2022

Tested:
image
image
image

@Tostti Tostti linked an issue Dec 20, 2022 that may be closed by this pull request
Validate the agent name field in the "Deploy a new agent" section #4927
Closed
@Tostti Tostti marked this pull request as ready for review December 20, 2022 18:56
@Tostti Tostti requested a review from a team as a code owner December 20, 2022 18:56
asteriscos
asteriscos previously approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

Evidence

image

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.65% ( 3195 / 36919 )
Branches 4.44% ( 1274 / 28649 )
Functions 7.54% ( 691 / 9157 )
Lines 8.71% ( 3082 / 35350 )

Desvelao
Desvelao approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

Code 🟢

Tests

Scenario Result
1 🟢
Scenario 1 🟢

image

@Desvelao Desvelao added the type/enhancement Enhancement issue label Dec 21, 2022
@Desvelao Desvelao merged commit e507b41 into 4.4-2.4-wzd Dec 21, 2022
@Desvelao Desvelao deleted the backport-5021-to-4.4-2.4-wzd branch December 21, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@Tostti Tostti

Labels
type/enhancement Enhancement issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate the agent name field in the "Deploy a new agent" section
3 participants
@Tostti @asteriscos @Desvelao