Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 7.10.2] Fixed the manager option in the agent deployment section #5025

Merged
merged 2 commits into from
Dec 21, 2022
Merged

[Backport 7.10.2] Fixed the manager option in the agent deployment section #5025

merged 2 commits into from
Dec 21, 2022

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Dec 21, 2022 •
edited
Loading

Backport from 65e156b

Description

Added options if you are in manager mode instead of cluster mode

Issues Resolved

Evidence

Screencast.from.12-12-2022.05.15.44.PM.webm

Environment

  • Have an environment in manager mode

Test

  • Enter wazuh and in the module overview the toast should not appear with error 3013.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano
Fixed the manager option in the agent deployment section (#4981)
3aae5d5 
* add manager option

* add changelog

* add changelog

* fix test

* fix typo

* add getCookies and getHttp (test)

* Fixed unit tests

* fix comment

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
Co-authored-by: Maximiliano Ibarra <maximiliano.ibarra@wazuh.com>
(cherry picked from commit 65e156b)
@yenienserrano
Update CHANGELOG.md
9d80a21
@yenienserrano yenienserrano requested a review from a team as a code owner December 21, 2022 15:54
@yenienserrano yenienserrano linked an issue Dec 21, 2022 that may be closed by this pull request
Toast with error 3013 in Kibana #4938
Closed
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.7% ( 3219 / 36987 )
Branches 4.45% ( 1278 / 28712 )
Functions 7.6% ( 697 / 9170 )
Lines 8.77% ( 3106 / 35414 )

Machi3mfl
Machi3mfl approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

@yenienserrano yenienserrano changed the title Backport 4981 to 4.4 7.10 [Backport 7.10.2] Fixed the manager option in the agent deployment section Dec 21, 2022
@yenienserrano yenienserrano merged commit dd42b1c into 4.4-7.10 Dec 21, 2022
@yenienserrano yenienserrano deleted the backport-4981-to-4.4-7.10 branch December 21, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Machi3mfl Machi3mfl Machi3mfl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toast with error 3013 in Kibana
2 participants
@yenienserrano @Machi3mfl