Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable expanded header in Wazuh Dashboard #5048

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Disable expanded header in Wazuh Dashboard #5048

merged 2 commits into from
Dec 29, 2022

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Dec 28, 2022 •
edited by AlexRuiz7
Loading

Description

This pull requests disables the expanded header (black top bar) by adding this configuration to the opensearch_dashboards.yml file

opensearchDashboards.branding:
  useExpandedHeader: false

Evidence

With useExpandedHeader: false

image

Without useExpandedHeader: false

image

Test

Start environments and see that the black header has disappeared.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano requested a review from a team as a code owner December 28, 2022 20:19
AlexRuiz7
AlexRuiz7 previously approved these changes Dec 29, 2022
View reviewed changes
@AlexRuiz7 AlexRuiz7 changed the title add useExpandedHeader config to the environment Disable expanded header in Wazuh Dashboard Dec 29, 2022
asteriscos
asteriscos reviewed Dec 29, 2022
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems it will need some additional styling changes. Take a look at the main Wazuh navigation menu:

image

@yenienserrano yenienserrano linked an issue Dec 29, 2022 that may be closed by this pull request
Disable expanded header in Wazuh Dashboard #5049
Closed
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.7% ( 3217 / 36944 )
Branches 4.57% ( 1313 / 28696 )
Functions 7.54% ( 691 / 9155 )
Lines 8.77% ( 3104 / 35377 )

asteriscos
asteriscos approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

Screenshot from 2022-12-29 16-41-19
Screenshot from 2022-12-29 16-44-15

@yenienserrano yenienserrano merged commit 461341c into 4.4-2.4-wzd Dec 29, 2022
@yenienserrano yenienserrano deleted the remove-header-opensearch-dashboards branch December 29, 2022 16:09
@yenienserrano yenienserrano mentioned this pull request Dec 30, 2022
Closed
@Desvelao
Copy link
Member

Desvelao commented Jan 9, 2023

I think I found a related problem with one of the changes included in this PR.

When scrolling vertically, and open the plugin menu, the menu content panel is displayed in the wrong place.

image

@yenienserrano yenienserrano mentioned this pull request Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@AlexRuiz7 AlexRuiz7 AlexRuiz7 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable expanded header in Wazuh Dashboard
4 participants
@yenienserrano @Desvelao @asteriscos @AlexRuiz7