[Backport 4.4-7.16] Fix password input in deploy new agent section #5110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* register agent section: password * changelog * fixed solaris, hp and alpine password input and added some styles * fixed the textToCopy error displayed in the console (cherry picked from commit b3b0222)
Desvelao
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
review:
Kibana 7.16
Legend:
⚫: none
🟢: passed
🔴: failed
🟡: warning
⚪: not applicable
| Test | Chrome | Package |
|---|---|---|
| Check that the 'Wazuh password' input does not appear in the deploy new agent section. | 🟢 | Kibana 7.16 |
| Control that depending on whether the switch is activated or not the hidden password is shown with **** or the previously defined password is shown. | 🟢 | Kibana 7.16 |
| Try to choose HP, Solaris or Alpine, check that the variable WAZUH_REGISTRATION_PASSWORD='hello' does not appear in the install command and that the 'show password' switch does not appear either. | 🟢 | Kibana 7.16 |
| Check that the 'Wazuh password' entry appears in the deploy new agent section and that you can enter a password without having selected an os yet. | 🟢 | Kibana 7.16 |
| Check that depending on whether the switch is activated or not the hidden password is shown with **** or the password you typed in is shown | 🟢 | Kibana 7.16 |
| Choose some operating system other than hp, alpine or solaris put a password, check that the hide password switch works fine | 🟢 | Kibana 7.16 |
| Choose some operating system other than HP, Alpine or Solaris set a password, check that the password hiding switch works fine, now choose HP, Solaris or Alpine check that the ui is not broken. | 🟢 | Kibana 7.16 |
| Try choosing hp, solaris or alpine, the password input and the switch should not appear. | 🟢 | Kibana 7.16 |
Details
🟢 Check that the 'Wazuh password' input does not appear in the deploy new agent section.
Chrome - 🟢
🟢 Control that depending on whether the switch is activated or not the hidden password is shown with **** or the previously defined password is shown.
Chrome - 🟢
🟢 Try to choose HP, Solaris or Alpine, check that the variable WAZUH_REGISTRATION_PASSWORD='hello' does not appear in the install command and that the 'show password' switch does not appear either.
Chrome - 🟢
🟢 Check that the 'Wazuh password' entry appears in the deploy new agent section and that you can enter a password without having selected an os yet.
Chrome - 🟢
⚫ Check that depending on whether the switch is activated or not the hidden password is shown with **** or the password you typed in is shown
Chrome - ⚫
🟢 Choose some operating system other than hp, alpine or solaris put a password, check that the hide password switch works fine
Chrome - 🟢
🟢 Choose some operating system other than HP, Alpine or Solaris set a password, check that the password hiding switch works fine, now choose HP, Solaris or Alpine check that the ui is not broken.
Chrome - 🟢
🟢 Try choosing hp, solaris or alpine, the password input and the switch should not appear.
Chrome - 🟢
asteriscos
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b3b0222 from #5098.