Fix button styling in event view #5137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desvelao
reviewed
Jan 18, 2023
...c/kibana-integrations/discover/application/angular/doc_table/components/table_row/_open.scss
Show resolved
Hide resolved
|
Desvelao
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
review
code: 🟢
Wazuh dashboard
Legend:
⚫: none
🟢: passed
🔴: failed
🟡: warning
⚪: not applicable
Environment:
Platform: Wazuh dashboard
| Test | Chrome | Firefox | Safari |
|---|---|---|---|
| The button should have the same appearance as the button that appears in Discover when the information is not displayed | 🟢 | 🟢 | ⚫ |
| The button should have the same appearance as the button that appears in Discover when after clicking to see the information. | 🟢 | 🟢 | ⚫ |
Details
🟢 The button should have the same appearance as the button that appears in Discover when the information is not displayed
Chrome - 🟢
Firefox - 🟢
Safari - ⚫
🟢 The button should have the same appearance as the button that appears in Discover when after clicking to see the information.
Chrome - 🟢
Firefox - 🟢
Safari - ⚫
Tostti
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
review
Wazuh dashboard
Legend:
⚫: none
🟢: passed
🔴: failed
🟡: warning
⚪: not applicable
Environment:
Platform: Wazuh dashboard
| Test | Chrome | Firefox | Safari |
|---|---|---|---|
| The button should have the same appearance as the button that appears in Discover when the information is not displayed | 🟢 | 🟢 | ⚫ |
| The button should have the same appearance as the button that appears in Discover when after clicking to see the information. | 🟢 | 🟢 | ⚫ |
Details
🟢 The button should have the same appearance as the button that appears in Discover when the information is not displayed
Chrome - 🟢
Discover
Wazuh
Firefox - 🟢
Discover
Wazuh
Safari - ⚫
🟢 The button should have the same appearance as the button that appears in Discover when after clicking to see the information.
Chrome - 🟢
Discover
Wazuh
Firefox - 🟢
Discover
Wazuh
Safari - ⚫
TEST:✔️
CR:✔️
LGTM
|
We should test it with the Safari browser as possible. |
chantal-kelm
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
review
code: 🟢
Wazuh dashboard
Legend:
⚫: none
🟢: passed
🔴: failed
🟡: warning
⚪: not applicable
Environment:
Platform: Wazuh dashboard
| Test | Chrome | Firefox | Safari |
|---|---|---|---|
| The button should have the same appearance as the button that appears in Discover when the information is not displayed | 🟢 | 🟢 | 🟢 |
| The button should have the same appearance as the button that appears in Discover when after clicking to see the information. | 🟢 | 🟢 | 🟢 |
Evidence
Chrome - 🟢
Firefox - 🟢
Safari - 🟢
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.10 4.4-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.10
# Create a new branch
git switch --create backport-5137-to-4.4-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 57f0e9fab6fa9dbfb8f0b396f8a7d1ae52317607
# Push it to GitHub
git push --set-upstream origin backport-5137-to-4.4-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.10Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-5137-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 57f0e9fab6fa9dbfb8f0b396f8a7d1ae52317607
# Push it to GitHub
git push --set-upstream origin backport-5137-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16Then, create a pull request where the |
AlexRuiz7
pushed a commit
that referenced
this pull request
Jan 31, 2023
* add new style * add changelog Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com> (cherry picked from commit 57f0e9f)
AlexRuiz7
pushed a commit
that referenced
this pull request
Jan 31, 2023
* add new style * add changelog Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com> (cherry picked from commit 57f0e9f)
AlexRuiz7
added a commit
that referenced
this pull request
Jan 31, 2023
* Fix button styling in event view (#5137) * add new style * add changelog Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com> (cherry picked from commit 57f0e9f) * Fix Events open row button styles --------- Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com> Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
AlexRuiz7
added a commit
that referenced
this pull request
Jan 31, 2023
* Fix button styling in event view (#5137) * add new style * add changelog Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com> (cherry picked from commit 57f0e9f) * Fix details button style classes --------- Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com> Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the styles of the button that shows more information of each row of the table in events so that it has the same styles as the button that appears in discover.
Issues Resolved
Evidence
Wazuh
Discover
Test
Scenario 1 The button should have the same appearance as the button that appears in Discover when the information is not displayed.
When the user navigates to a module/events
Then should see the button like the one shown in Discover
Scenario 2 The button should have the same appearance as the button that appears in Discover when after clicking to see the information.
When the user navigates to a module/events and click to see the information
Then should see the button like the one shown in Discover
Check List
yarn test:jest