Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 4.4-7.16] Disable synced by default #5169

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Backport 311622a from #5143.

* Disable synced by default

* Fix column default properties

* Add changelog

* Remove synced KPI from management status

* Fix typos, agent table width style and os.platform

* Replace OS to operating system and IP to IP address

* Change OS to operating system

* Fix agent table layout

* Change IP to IP address in cluster overview

* Fix extendedInformation

* Fix style columnsSelectedCheckboxs

* Remove truncate property of columns

* Add table overflow auto

* Change OS version to flexItem

* Change OS version gutter size

(cherry picked from commit 311622a)
@github-actions github-actions bot requested a review from a team as a code owner January 26, 2023 13:46
@Desvelao Desvelao linked an issue Jan 27, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor Author

Code coverage (Jest) % values
Statements 8.6% ( 3254 / 37838 )
Branches 4.41% ( 1291 / 29251 )
Functions 7.48% ( 703 / 9396 )
Lines 8.67% ( 3139 / 36187 )

@chantal-kelm chantal-kelm self-requested a review January 27, 2023 10:17
@Desvelao
Copy link
Member

Desvelao commented Jan 27, 2023

Kibana 7.17.6

Legend:
⚫: none
🟢: passed
🔴: failed
🟡: warning
⚪: not applicable

UI

Test Chrome Firefox Safari
Synced field - Registration Date - Last Keep Alive 🟢 🟢
Replace OS to Operating system and IP to IP address - Agents table 🟢 🟢
Replace OS to Operating system and IP to IP address - Agents Inventory PDF report 🟢 🟢
Replace OS to Operating system and IP to IP address - Groups agents table 🟢 🟢
Replace OS to Operating system and IP to IP address - Agent overview 🟢 🟢
Replace OS to Operating system and IP to IP address - Management cluster 🟢 🟢
Replace OS to Operating system and IP to IP address - Office365 Panel 🟢 🟢
Replace OS to Operating system and IP to IP address - Global Configuration Remote 🟢 🟢
Replace OS to Operating system and IP to IP address - Explore Agent modal 🟢 🟢
Redistribute Agents Table column widths automatically 🟢 🟢
Verify all main agents operating system have the proper icon in the table 🟢 🟢

Details

🟢 Synced field - Registration Date - Last Keep Alive

Chrome - 🟢
image

Firefox - 🟢
image

Safari - ⚫

🟢 Replace OS to Operating system and IP to IP address - Agents table

Chrome - 🟢
image

Firefox - 🟢
image

Safari - ⚫

🟢 Replace OS to Operating system and IP to IP address - Agents Inventory PDF report

Chrome - 🟢
image
image
image

Firefox - 🟢
image
image
image

Safari - ⚫

🟢 Replace OS to Operating system and IP to IP address - Groups agents table

Chrome - 🟢
image

Firefox - 🟢
image

Safari - ⚫

🟢 Replace OS to Operating system and IP to IP address - Agent overview

Chrome - 🟢
image

Firefox - 🟢
image

Safari - ⚫

🟢 Replace OS to Operating system and IP to IP address - Management cluster

Chrome - 🟢
image

Firefox - 🟢
image

Safari - ⚫

🟢 Replace OS to Operating system and IP to IP address - Office365 Panel

Chrome - 🟢
image
image

Firefox - 🟢
image
image

Safari - ⚫

🟢 Replace OS to Operating system and IP to IP address - Global Configuration Remote

Chrome - 🟢
image

Firefox - 🟢
image

Safari - ⚫

🟢 Replace OS to Operating system and IP to IP address - Explore Agent modal

Chrome - 🟢
image

Firefox - 🟢
image

Safari - ⚫

🟢 Redistribute Agents Table column widths automatically

Chrome - 🟢
image

Firefox - 🟢
image

Safari - ⚫

🟢 Verify all main agents operating system have the proper icon in the table

Chrome - 🟢
image

Firefox - 🟢
image

Safari - ⚫

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

code 🟢
tests 🟢
#5169 (comment)

Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
TEST: ✅

Replace OS to Operating system and IP to IP address

Agents table 🟢

Chrome 🟢

image

Firefox 🟢

image

Safari 🟢

image

Agents Inventory PDF report 🟢

Chrome 🟢

image image

Firefox 🟢

image image

Safari 🟢

image image

Groups agents table 🟢

Chrome 🟢

image

Firefox 🟢

image

Safari 🟢

image

Agent overview 🟢

Chrome 🟢

image

Firefox 🟢

image

Safari 🟢

image

Management cluster 🟢

Chrome 🟢

image image

Firefox 🟢

image image

Safari 🟢

image image

Office365 Panel 🟢

Chrome 🟢

image image

Firefox 🟢

image image

Safari 🟢

image image

Global Configuration Remote 🟢

Chrome 🟢

image

Firefox 🟢

image

Safari 🟢

image

Explore Agent modal 🟢

Chrome 🟢

image

Firefox 🟢

image

Safari 🟢

image

Redistribute Agents Table column widths automatically 🟢

Chrome 🟢

image

Firefox 🟢

image

Safari 🟢

image

@asteriscos asteriscos merged commit d36345f into 4.4-7.16 Jan 27, 2023
@asteriscos asteriscos deleted the backport-5143-to-4.4-7.16 branch January 27, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable sync information in agent table by default
3 participants