Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 4.4-7.16] Added server address and wazuh protocol definition in Deploy agent section #5172

Merged
merged 4 commits into from
Jan 27, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Backport b167d6c from #5166.

…ction (#5166)

* Added new WzServerAddressInput component

* Updated CHANGELOG

* Update state server address when is mounted

* Resolved review comments

* Updated CHANGELOG

* Updated logic when protocol is UDP

* Modified wazuh protocol param definition

* Changed PR text in CHANGELOG

* Reverted changes tsconfig

(cherry picked from commit b167d6c)
@github-actions
Copy link
Contributor Author

Code coverage (Jest) % values
Statements 8.6% ( 3256 / 37851 )
Branches 4.41% ( 1291 / 29259 )
Functions 7.48% ( 703 / 9401 )
Lines 8.68% ( 3141 / 36201 )

@Desvelao
Copy link
Member

review:

code 🟢

Tests

Kibana 7.17.6

WIP

Legend:
⚫: none
🟢: passed
🔴: failed
🟡: warning
⚪: not applicable

UI

Test Chrome Firefox Safari
For a manager master (cluster mode) configurated as TCP and UDP as the protocols of the remote secure connection, uses the TCP protocol. It should not display the WAZUH_PROTOCOL deployment variable 🟢 🟢
For a manager master (cluster mode) configurated as TCP as the protocol of the remote secure connection, uses the TCP protocol. It should not display the WAZUH_PROTOCOL deployment variable 🟢 🟢
For a manager master (cluster mode) configurated as UDP as the protocol of the remote secure connection, uses the UDP protocol. It should display the WAZUH_PROTOCOL deployment variable with UDP value 🟢 🟢
For a manager master (manager mode) configurated as TCP and UDP as the protocols of the remote secure connection, uses the TCP protocol. It should not display the WAZUH_PROTOCOL deployment variable 🟢 🟢
For a manager master (cluster mode) configurated as TCP as the protocol of the remote secure connection, uses the TCP protocol. It should not display the WAZUH_PROTOCOL deployment variable 🟢 🟢
For a manager master (manager mode) configurated as UDP as the protocol of the remote secure connection, uses the UDP protocol. It should display the WAZUH_PROTOCOL deployment variable with UDP value 🟢 🟢

Details

🟢 For a manager master (cluster mode) configurated as TCP and UDP as the protocols of the remote secure connection, uses the TCP protocol. It should not display the WAZUH_PROTOCOL deployment variable

Chrome - 🟢
image

Firefox - 🟢
image

Safari - ⚫

🟢 For a manager master (cluster mode) configurated as TCP as the protocol of the remote secure connection, uses the TCP protocol. It should not display the WAZUH_PROTOCOL deployment variable

Chrome - 🟢
image

Firefox - 🟢
image

Safari - ⚫

🟢 For a manager master (cluster mode) configurated as UDP as the protocol of the remote secure connection, uses the UDP protocol. It should display the WAZUH_PROTOCOL deployment variable with UDP value

Chrome - 🟢
image

Firefox - 🟢
image

Safari - ⚫

🟢 For a manager master (manager mode) configurated as TCP and UDP as the protocols of the remote secure connection, uses the TCP protocol. It should not display the WAZUH_PROTOCOL deployment variable

Chrome - 🟢
image

Firefox - 🟢
image

Safari - ⚫

🟢 For a manager master (cluster mode) configurated as TCP as the protocol of the remote secure connection, uses the TCP protocol. It should not display the WAZUH_PROTOCOL deployment variable

Chrome - 🟢
image

Firefox - 🟢
image

Safari - ⚫

🟢 For a manager master (manager mode) configurated as UDP as the protocol of the remote secure connection, uses the UDP protocol. It should display the WAZUH_PROTOCOL deployment variable with UDP value

Chrome - 🟢
image

Firefox - 🟢
image

Safari - ⚫

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:

code 🟢
tests: 🟢
#5172 (comment)

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

Cluster mode - With Enrollment - UDP - 🟢

image

Cluster mode - Without Enrollment - UDP - 🟢

image

Cluster mode - TCP - 🟢

image

Manager mode - TCP - 🟢

image

Manager mode - UDP - 🟢

image

@asteriscos asteriscos merged commit feae7a5 into 4.4-7.16 Jan 27, 2023
@asteriscos asteriscos deleted the backport-5166-to-4.4-7.16 branch January 27, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants