Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backport 5137 to 4.4 7.16 - change button text color #5186

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Fix backport 5137 to 4.4 7.16 - change button text color #5186

merged 1 commit into from
Jan 31, 2023

Conversation

asteriscos
Copy link
Member

Description

Team,

this PR changes the color of the > button in the Security events / Events rows. The button style should match the Kibana Discover plugin.

Important: This must only be applied to the 7.16.x dev branch.

Related Pull request #5184

Evidence

Security events
image

Discover
image

Test

  • Verify the color of the > button in the Security events / Events rows.
  • Check it matches the Kibana Discover plugin row button style.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos requested a review from a team as a code owner January 31, 2023 12:21
@asteriscos asteriscos self-assigned this Jan 31, 2023
Tostti
Tostti approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discover

imagen
imagen

Wazuh

imagen
imagen

TEST:✔️
CR:✔️

LGTM

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.6% ( 3256 / 37851 )
Branches 4.41% ( 1291 / 29259 )
Functions 7.48% ( 703 / 9401 )
Lines 8.68% ( 3141 / 36201 )

@asteriscos asteriscos merged commit acd47e3 into 4.4-7.16 Jan 31, 2023
@asteriscos asteriscos deleted the fix/backport-5137-to-4.4-7.16 branch January 31, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tostti Tostti Tostti approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asteriscos @Tostti