Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 4.5-7.10] Add ignore and restrict fields #5223

Merged
merged 2 commits into from
Mar 8, 2023
Merged

[Backport 4.5-7.10] Add ignore and restrict fields #5223

merged 2 commits into from
Mar 8, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Backport 326b874 from #5203.

@yenienserrano @github-actions
Add ignore and restrict fields (#5203)
2661572 
* Add ignore and restrict fields

* change labels

* add changelog

* Remove the last dot

(cherry picked from commit 326b874)
@github-actions github-actions bot requested a review from a team as a code owner February 23, 2023 09:29
@Desvelao
Copy link
Member

Desvelao commented Feb 23, 2023 •
edited
Loading

Kibana 7.10.2

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox
Defined ignore field in the API response should display the value as expected 🟢 🟢
Defined restrict field in the API response should display the value as expected 🟢 🟢
Defined ignore and restrict fields in the API response should display the value as expected 🟢 🟢
Not defined ignore and restrict field should render a placeholder (-) 🟢 🟢

Details

🟢 Defined ignore field in the API response should display the value as expected

Chrome - 🟢
image

Firefox - 🟢
image

🟢 Defined restrict field in the API response should display the value as expected

Chrome - 🟢
image

Firefox - 🟢
image

🟢 Defined ignore and restrict fields in the API response should display the value as expected

Chrome - 🟢
image

Firefox - 🟢
image

🟢 Not defined ignore and restrict field should render a placeholder (-)

Chrome - 🟢
image

Firefox - 🟢
image

Desvelao
Desvelao reviewed Feb 23, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

🟢 code
🟢 test #5223 (comment)

@Desvelao Desvelao linked an issue Feb 23, 2023 that may be closed by this pull request
Add ignore and restrict options to localfile configuration #4628
Closed
@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 8, 2023

Code coverage (Jest) % values
Statements 8.86% ( 3277 / 36999 )
Branches 4.53% ( 1302 / 28744 )
Functions 7.73% ( 708 / 9164 )
Lines 8.92% ( 3160 / 35428 )

yenienserrano
yenienserrano approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test: ✅

image

@yenienserrano yenienserrano merged commit 8164e50 into 4.5-7.10 Mar 8, 2023
@yenienserrano yenienserrano deleted the backport-5203-to-4.5-7.10 branch March 8, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@Desvelao Desvelao Desvelao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ignore and restrict options to localfile configuration
2 participants
@Desvelao @yenienserrano