Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 4.5-7.16] Change RexExp #5226

Merged
merged 1 commit into from
Mar 8, 2023
Merged

[Backport 4.5-7.16] Change RexExp #5226

merged 1 commit into from
Mar 8, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Backport 8f51a0a from #5201.

@yenienserrano @github-actions
Change RexExp (#5201)
fbbe6fa 
* change RexExp

* add changelog

(cherry picked from commit 8f51a0a)
@github-actions github-actions bot requested a review from a team as a code owner February 23, 2023 09:32
@Desvelao Desvelao linked an issue Feb 23, 2023 that may be closed by this pull request
Remove unneeded string substitution #5037
Closed
6 tasks
@Desvelao
Copy link
Member

Desvelao commented Feb 23, 2023 •
edited
Loading

Kibana 7.16.3

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Log in with a user with full permissions and see if the application works as expected 🟢 🟢 ⚫
Log in with a user with reduced permissions and check if the application works as expected 🟢 🟢 ⚫

Details

🟢 Log in with a user with full permissions and see if the application works as expected

Chrome - 🟢

Firefox - 🟢

Safari - ⚫

🟢 Log in with a user with reduced permissions and check if the application works as expected

Chrome - 🟢
image
image

Firefox - 🟢
image
image

Safari - ⚫

Other

Test Result
Unit tests should pass. Manually execution. 🟢

Details

🟢 Unit tests should pass. Manually execution.

image

Desvelao
Desvelao approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

🟢 code
🟢 test #5226 (comment)

@yenienserrano yenienserrano merged commit c686c40 into 4.5-7.16 Mar 8, 2023
@yenienserrano yenienserrano deleted the backport-5201-to-4.5-7.16 branch March 8, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@Desvelao Desvelao Desvelao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unneeded string substitution
2 participants
@Desvelao @yenienserrano