Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 4.5-7.16] Remove trailing - character for OS value in the list of agents #5265

Merged
merged 2 commits into from
Mar 9, 2023
Merged

[Backport 4.5-7.16] Remove trailing - character for OS value in the list of agents #5265

merged 2 commits into from
Mar 9, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 7, 2023

Backport 6a50c9b from #4828.

@asteriscos @github-actions
Remove trailing - character for OS value in the list of agents (#4828)
c235acb 
* Remove - character when version is empty

* Simplify field default value

* Add changelog

* Update CHANGELOG.md

* Update CHANGELOG.md

* Change group default value to -

* Conflit resolution

---------

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 6a50c9b)
@github-actions github-actions bot requested a review from a team as a code owner March 7, 2023 14:54
@Desvelao
Copy link
Member

Desvelao commented Mar 9, 2023 •
edited
Loading

Kibana 7.16.3

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox
Verify empty fields contain a - value 🟢 🟢
Verify the OS column has a - only if it's empty 🟢 🟢
Verify that if the OS has only the name, but has no version then it doesn't include a - separator 🟢 🟢

Details

🟢 Verify empty fields contain a - value

Chrome - 🟢
image

Firefox - 🟢
image

🟢 Verify the OS column has a - only if it's empty

Chrome - 🟢
image
image

Firefox - 🟢
image
image

🟢 Verify that if the OS has only the name, but has no version then it doesn't include a - separator

Chrome - 🟢
image

Firefox - 🟢
image

@Desvelao Desvelao linked an issue Mar 9, 2023 that may be closed by this pull request
Trailing - character for OS value in the list of agents #4809
Closed
@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 9, 2023

Code coverage (Jest) % values
Statements 8.65% ( 3275 / 37869 )
Branches 4.44% ( 1300 / 29279 )
Functions 7.51% ( 706 / 9404 )
Lines 8.72% ( 3158 / 36219 )

Desvelao
Desvelao approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:

🟢 code
🟢 test #5265 (comment)

yenienserrano
yenienserrano approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@AlexRuiz7 AlexRuiz7 merged commit b8fca7b into 4.5-7.16 Mar 9, 2023
@AlexRuiz7 AlexRuiz7 deleted the backport-4828-to-4.5-7.16 branch March 9, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@Desvelao Desvelao Desvelao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trailing - character for OS value in the list of agents
4 participants
@Desvelao @yenienserrano @AlexRuiz7 @asteriscos