Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 5196 to 4.4-7.10] Fix the search in the agent inventory data tables #5346

Merged
merged 2 commits into from
Mar 31, 2023
Merged

[Backport 5196 to 4.4-7.10] Fix the search in the agent inventory data tables #5346

merged 2 commits into from
Mar 31, 2023

Conversation

Desvelao
Copy link
Member

Backport 4fadc4e from #5196.

@Desvelao
Fix the search in the agent inventory data tables (#5196)
d5bfd9d 
* fix: change the search in the agents inventory tables

- Replace search by q API parameter

* changelog: add pull request entry

* fix(agent-inventory): change the search bar placeholder to `Search`

* fix(changelog): fix entry

* fix: replace string

* fix(changelog): moved entry to Fixed

---------

Co-authored-by: Nicolas Agustin Guevara Pihen <42900763+Tostti@users.noreply.github.com>
(cherry picked from commit 4fadc4e)
@Desvelao Desvelao requested a review from a team as a code owner March 31, 2023 07:32
@Desvelao Desvelao self-assigned this Mar 31, 2023
@Desvelao Desvelao changed the base branch from master to 4.4-7.10 March 31, 2023 07:32
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.81% ( 3257 / 36982 )
Branches 4.48% ( 1287 / 28697 )
Functions 7.68% ( 703 / 9159 )
Lines 8.87% ( 3142 / 35413 )

@Desvelao Desvelao changed the title [Backport 5196 to 4.4-7.16] Fix the search in the agent inventory data tables [Backport 5196 to 4.4-7.10] Fix the search in the agent inventory data tables Mar 31, 2023
@Desvelao Desvelao linked an issue Mar 31, 2023 that may be closed by this pull request
Fix the search in the agents inventory table #5198
Closed
@yenienserrano
Copy link
Member

yenienserrano commented Mar 31, 2023 •
edited by Desvelao
Loading

Kibana 7.10.2

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Empty input in the search bar of the agent inventory tables should display all the results 🟢 ⚫ ⚫
Add a search text input in the search bar of the agent inventory tables should display filtered the results 🟢 ⚫ ⚫
Export to CSV each table in agents inventory with an empty search query should display all the results 🟢 ⚫ ⚫
Export to CSV each table in agents inventory with a search query should display results filtered 🟢 ⚫ ⚫

Details

🟢 Empty input in the search bar of the agent inventory tables should display all the results

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Add a search text input in the search bar of the agent inventory tables should display filtered the results

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Export to CSV each table in agents inventory with an empty search query should display all the results

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Export to CSV each table in agents inventory with a search query should display results filtered

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

yenienserrano
yenienserrano approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: #5346 (comment)

@yenienserrano yenienserrano merged commit db5aabb into 4.4-7.10 Mar 31, 2023
@yenienserrano yenienserrano deleted the backport-5196-to-4.4-7.10 branch March 31, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@Desvelao Desvelao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the search in the agents inventory table
2 participants
@Desvelao @yenienserrano