-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the GitHub and Office 365 module visibility configuration were not kept when changing the plugin #5376
Fix the GitHub and Office 365 module visibility configuration were not kept when changing the plugin #5376
Conversation
…e plugin - Add the extensions.github and extensions.office to the plugin configuration file - Enhance tests related to the extension configuration when changing the plugin
…onfiguration-on-upgrade-plugin
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.10 4.5-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.10
# Create a new branch
git switch --create backport-5376-to-4.5-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a62f2d51c6482855175e4374610dc07da87506fc
# Push it to GitHub
git push --set-upstream origin backport-5376-to-4.5-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.10 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.16 4.5-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.16
# Create a new branch
git switch --create backport-5376-to-4.5-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a62f2d51c6482855175e4374610dc07da87506fc
# Push it to GitHub
git push --set-upstream origin backport-5376-to-4.5-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.16 Then, create a pull request where the |
…t kept when changing the plugin (#5376) * fix: fix the GitHub and Office 365 module visibility when changing the plugin - Add the extensions.github and extensions.office to the plugin configuration file - Enhance tests related to the extension configuration when changing the plugin * fix: typos * changelog: add pull request entries --------- Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit a62f2d5)
…t kept when changing the plugin (#5376) * fix: fix the GitHub and Office 365 module visibility when changing the plugin - Add the extensions.github and extensions.office to the plugin configuration file - Enhance tests related to the extension configuration when changing the plugin * fix: typos * changelog: add pull request entries --------- Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit a62f2d5)
…onfiguration were not kept when changing the plugin (#5389) * Fix the GitHub and Office 365 module visibility configuration were not kept when changing the plugin (#5376) * fix: fix the GitHub and Office 365 module visibility when changing the plugin - Add the extensions.github and extensions.office to the plugin configuration file - Enhance tests related to the extension configuration when changing the plugin * fix: typos * changelog: add pull request entries --------- Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit a62f2d5) * Update snapshot --------- Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
…onfiguration were not kept when changing the plugin (#5388) * Fix the GitHub and Office 365 module visibility configuration were not kept when changing the plugin (#5376) * fix: fix the GitHub and Office 365 module visibility when changing the plugin - Add the extensions.github and extensions.office to the plugin configuration file - Enhance tests related to the extension configuration when changing the plugin * fix: typos * changelog: add pull request entries --------- Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit a62f2d5) * Update snapshot --------- Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
Description
This pull request fixes a problem when the visibility of GitHub and Office 365 modules are not kept when changing/upgrading the plugin.
Changes:
extensions.github
andextensions.office
settings to the default configuration fileRelated pull request (documentation): wazuh/wazuh-documentation#6036
Issues Resolved
Test
UI
Other
template_testing.md
Check List
yarn test:jest