Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repeated request in groups-table #5465

Merged
merged 4 commits into from
May 29, 2023
Merged

Fix repeated request in groups-table #5465

merged 4 commits into from
May 29, 2023

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented May 19, 2023 •
edited
Loading

Description

Fixes repeated requests in the group table when adding a group or refreshing the table

Issues Resolved

Evidence

Details

Refresh

image

Add new group

image

image

Test

  1. Navigate to Management/groups
  2. Click on Refresh | Add new group
  3. See requests in the console

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Requests in Refresh ⚫ ⚫ ⚫
Requests in Add new group ⚫ ⚫ ⚫

Details

⚫ Requests in `Refresh`

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Requests in `Add new group`

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano requested a review from a team as a code owner May 19, 2023 11:44
@yenienserrano yenienserrano self-assigned this May 19, 2023
@yenienserrano yenienserrano linked an issue May 19, 2023 that may be closed by this pull request
Wazuh API usage - Manament repeated requests #5241
Closed
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 9.46% ( 3506 / 37034 )
Branches 4.99% ( 1434 / 28698 )
Functions 8.13% ( 747 / 9178 )
Lines 9.54% ( 3386 / 35467 )

@Desvelao
Copy link
Member

Wazuh dashboard

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Verify that there are not repeated request when using the Add new group button in Management > Groups 🟢 ⚫ ⚫
Verify that there are not repeated request when using the Refresh button in Management > Groups 🟢 ⚫ ⚫

Details

🟢 Verify that there are not repeated request when using the Add new group button in Management > Groups

Chrome - 🟢
image
Firefox - ⚫

Safari - ⚫

🟢 Verify that there are not repeated request when using the Refresh button in Management > Groups

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

Desvelao
Desvelao approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

code 🟢
test 🟢 #5465 (comment)

@AlexRuiz7 AlexRuiz7 merged commit e4884fa into 4.5 May 29, 2023
@AlexRuiz7 AlexRuiz7 deleted the 5241-wazuh-api-usage-manament-repeated-requests branch May 29, 2023 12:22
@github-actions github-actions bot mentioned this pull request May 29, 2023
Merged
github-actions bot pushed a commit that referenced this pull request May 29, 2023
@yenienserrano @github-actions
Fix repeated request in groups-table (#5465)
4a149a9 
* Fix repeated request in groups-table

* Add changelog

* Add suggestion

(cherry picked from commit e4884fa)
@github-actions github-actions bot mentioned this pull request May 29, 2023
Merged
github-actions bot pushed a commit that referenced this pull request May 29, 2023
@yenienserrano @github-actions
Fix repeated request in groups-table (#5465)
da3ac59 
* Fix repeated request in groups-table

* Add changelog

* Add suggestion

(cherry picked from commit e4884fa)
AlexRuiz7 pushed a commit that referenced this pull request May 29, 2023
@github-actions @yenienserrano
[Backport 4.5-7.10] Fix repeated request in groups-table (#5498)
de1f0cc 
Fix repeated request in groups-table (#5465)

* Fix repeated request in groups-table

* Add changelog

* Add suggestion

(cherry picked from commit e4884fa)

Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
AlexRuiz7 pushed a commit that referenced this pull request May 29, 2023
@github-actions @yenienserrano
[Backport 4.5-7.16] Fix repeated request in groups-table (#5499)
746f7cb 
Fix repeated request in groups-table (#5465)

* Fix repeated request in groups-table

* Add changelog

* Add suggestion

(cherry picked from commit e4884fa)

Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
@AlexRuiz7 AlexRuiz7 mentioned this pull request Sep 11, 2023
Closed
8 tasks
@asteriscos asteriscos mentioned this pull request Sep 27, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

Assignees

@yenienserrano yenienserrano

Labels
backport 4.5-7.10 backport 4.5-7.16
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wazuh API usage - Manament repeated requests
3 participants
@yenienserrano @Desvelao @AlexRuiz7