Change the search bar to the one that does not make the request on rendering #5476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TestLegend: UI
Details 🟢 When navigating to management/logs there has to be only 1 request to /cluster/{node}/logsChrome - 🟢 Firefox - 🟢 Safari - ⚫ 🟢 When searching, the request must be made after a period of time without typingChrome - 🟢 Firefox - 🟢 Safari - ⚫ 🟢 When clearing the whole search, you have to make the request without searchChrome - 🟢 Firefox - 🟢 Safari - ⚫ |
Desvelao
approved these changes
May 29, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.10 4.5-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.10
# Create a new branch
git switch --create backport-5476-to-4.5-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c2944dc2cf36dae5f71f6620d52c42ad63a117fd
# Push it to GitHub
git push --set-upstream origin backport-5476-to-4.5-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.10Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.16 4.5-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.16
# Create a new branch
git switch --create backport-5476-to-4.5-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c2944dc2cf36dae5f71f6620d52c42ad63a117fd
# Push it to GitHub
git push --set-upstream origin backport-5476-to-4.5-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.16Then, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The search bar has been changed to the one used in the rest of the app. The search bar that was being used has been removed since it was the only place where this bar was used, and it also had the bug of the request when rendering.
Issues Resolved
Evidence
Screenshot
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Details
⚫ When navigating to management/logs there has to be only 1 request to /cluster/{node}/logs
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ When searching, the request must be made after a period of time without typing
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ When clearing the whole search, you have to make the request without search
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest