-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Register Agent] Add remember server address check #5791
Merged
Machi3mfl
merged 5 commits into
master
from
feat/4718-add-save-server-address-register-agent
Sep 29, 2023
Merged
[Register Agent] Add remember server address check #5791
Machi3mfl
merged 5 commits into
master
from
feat/4718-add-save-server-address-register-agent
Sep 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chantal-kelm
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jbiset
requested changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 🟡 (Request changes)
TEST UI 🟢
1. 🟢 When the user checks the Remember server address button this will save the value on the configuration
2. 🟢 When the server address input is not valid the toggle must be disabled
3. 🟢 When the server address is equal to the value saved on the configuration enrollment.dns setting the toggle must be checked
4. 🟢 When the server address value is valid and is not equal to the value saved in Configuration the toggle must be false.
plugins/main/public/controllers/register-agent/components/server-address/server-address.tsx
Outdated
Show resolved
Hide resolved
jbiset
approved these changes
Sep 29, 2023
|
Machi3mfl
deleted the
feat/4718-add-save-server-address-register-agent
branch
September 29, 2023 12:52
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added toggle
Remember server address
button to saveenrollment.dns
configuration when is checked.Issues Resolved
Closes #4718
Evidence
Test cases
1. When the user checks the
Remember server address
button this will save the value on the configuration2. When the server address input is
not valid
the toggle must bedisabled
Kazam_screencast_00004.mp4
3. When the server address is equal to the value saved on the configuration
enrollment.dns
setting the toggle must be checked4. When the server address value is valid and is not equal to the value saved in Configuration the toggle must be false.
Kazam_screencast_00005.mp4
Check List
yarn test:jest