Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Register Agent] Add remember server address check #5791

Merged
merged 5 commits into from
Sep 29, 2023

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Aug 17, 2023

Description

Added toggle Remember server address button to save enrollment.dns configuration when is checked.

Issues Resolved

Closes #4718

Evidence

image

Test cases

1. When the user checks the Remember server address button this will save the value on the configuration

image

image

2. When the server address input is not valid the toggle must be disabled

Kazam_screencast_00004.mp4

3. When the server address is equal to the value saved on the configuration enrollment.dns setting the toggle must be checked

image

image

4. When the server address value is valid and is not equal to the value saved in Configuration the toggle must be false.

Kazam_screencast_00005.mp4

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Machi3mfl Machi3mfl requested a review from a team as a code owner August 17, 2023 17:06
@chantal-kelm chantal-kelm self-requested a review August 17, 2023 18:37
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With unsaved IP:

Captura de pantalla 2023-08-17 a la(s) 15 45 25

With saved IP:

Captura de pantalla 2023-08-17 a la(s) 15 46 44 Captura de pantalla 2023-08-17 a la(s) 15 47 09

Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟡 (Request changes)

TEST UI 🟢

1. 🟢 When the user checks the Remember server address button this will save the value on the configuration

Evidence_1_remember_server_address_A

Evidence_1_remember_server_address_B

2. 🟢 When the server address input is not valid the toggle must be disabled

Evidence_2_invalid_IP_toggle_disabled_A

Evidence_2_invalid_IP_toggle_disabled_B

Evidence_2_invalid_IP_toggle_disabled_C

3. 🟢 When the server address is equal to the value saved on the configuration enrollment.dns setting the toggle must be checked

Evidence_3_valid_IP_saved_toggle_enabled

4. 🟢 When the server address value is valid and is not equal to the value saved in Configuration the toggle must be false.

Evidence_4_valid_IP_NOT_saved_toggle_disabled

@Machi3mfl Machi3mfl changed the base branch from 4.7.0 to master September 29, 2023 12:26
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 11.71% ( 4041 / 34507 )
Branches 7.96% ( 1855 / 23299 )
Functions 11.2% ( 925 / 8252 )
Lines 11.89% ( 3929 / 33042 )

@Machi3mfl Machi3mfl merged commit 63b6862 into master Sep 29, 2023
2 checks passed
@Machi3mfl Machi3mfl deleted the feat/4718-add-save-server-address-register-agent branch September 29, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to easily save the Wazuh server address in the "Deploy new agent" section
3 participants