Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Security Events table query filter #6102

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

asteriscos
Copy link
Member

Description

Hi team,
this pull request deprecates the useQuery hook which uses the method getDiscoverScope() of the legacy Discover. It replaces its implementation with the useQueryManager hook that makes use of the Data plugin to handle the query state.

Issues Resolved

Closes #6042

Evidence

Peek 2023-11-06 18-51

Test

  • Go to Security Events
  • Click in the input Query bar
  • Type a value, like 553 (a rule ID) and press "enter"
  • See the change apply to the visualizations and the table
  • Delete the value from the input Query bar and press enter
  • Check the values in the visualizations and the Security alerts table are correct

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos requested a review from a team as a code owner November 6, 2023 17:59
@asteriscos asteriscos self-assigned this Nov 6, 2023
@asteriscos asteriscos linked an issue Nov 6, 2023 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.95% ( 167 / 217 )
Branches 53.53% ( 53 / 99 )
Functions 60.86% ( 28 / 46 )
Lines 76.95% ( 167 / 217 )

Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test 🟢

Evidence

Evidence.webm

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Main plugin code coverage (Jest) test % values
Statements 11.94% ( 4110 / 34405 )
Branches 8.16% ( 1888 / 23126 )
Functions 11.22% ( 920 / 8199 )
Lines 12.11% ( 3995 / 32985 )

@yenienserrano yenienserrano self-requested a review November 7, 2023 11:40
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Screencast.from.2023-11-07.13-09-33.webm

@asteriscos asteriscos merged commit 74c493a into 4.8.0 Nov 7, 2023
3 checks passed
@asteriscos asteriscos deleted the fix/security-events-table-update-filters-6042 branch November 7, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security events dashboard filter is not updating events list
3 participants