Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade version axios #6114

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Upgrade version axios #6114

merged 3 commits into from
Nov 13, 2023

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Nov 13, 2023 •
edited
Loading

Description

This pull request upgrades the version of axios dependency.

Side changes:

  • Fix a problem with tests using axios. Use supertest instead.

Issues Resolved

#6113

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao requested a review from a team as a code owner November 13, 2023 12:14
@Desvelao Desvelao self-assigned this Nov 13, 2023
@Desvelao Desvelao linked an issue Nov 13, 2023 that may be closed by this pull request
Upgrade the version of axios #6113
Closed
asteriscos
asteriscos previously approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️

Test: ✔️

image

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.95% ( 167 / 217 )
Branches 54.63% ( 53 / 97 )
Functions 60.86% ( 28 / 46 )
Lines 76.95% ( 167 / 217 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.4% ( 183 / 897 )
Branches 18.07% ( 79 / 437 )
Functions 12.63% ( 36 / 285 )
Lines 20.59% ( 180 / 874 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 11.96% ( 4111 / 34371 )
Branches 8.16% ( 1888 / 23137 )
Functions 11.25% ( 920 / 8174 )
Lines 12.12% ( 3996 / 32957 )

@asteriscos asteriscos merged commit 2a6884b into 4.8.0 Nov 13, 2023
4 checks passed
@asteriscos asteriscos deleted the fix/idr-470-fix-vulnerability-axios-dependency branch November 13, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

Assignees

@Desvelao Desvelao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade the version of axios
2 participants
@Desvelao @asteriscos