-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix show call-out warning when there is no data in the vulnerabilities index #6173
Merged
asteriscos
merged 10 commits into
4.8.0
from
fix/6166-show-call-out-warning-when-there-is-no-data-in-the-vulnerabilities-index
Dec 1, 2023
Merged
Fix show call-out warning when there is no data in the vulnerabilities index #6173
asteriscos
merged 10 commits into
4.8.0
from
fix/6166-show-call-out-warning-when-there-is-no-data-in-the-vulnerabilities-index
Dec 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-no-data-in-the-vulnerabilities-index
Machi3mfl
approved these changes
Nov 30, 2023
EvidenceHealth check warning message when no indices match vulnerability index patternVulnerability detection dashboard when no indices match vulnerability index patternVulnerability detection inventory when no indices match vulnerability index patternHealth check when the vulnerability index existsVulnerability detector dashboard when the vulnerability index exists, but mapping is wrongVulnerability detector dashboard when the vulnerability index exists and mapping is correctVulnerability detector inventory when the vulnerability index exists and mapping is correct |
lucianogorza
approved these changes
Nov 30, 2023
Desvelao
reviewed
Dec 1, 2023
plugins/main/public/components/overview/vulnerabilities/common/components/no_results.tsx
Show resolved
Hide resolved
Desvelao
reviewed
Dec 1, 2023
plugins/main/public/components/overview/vulnerabilities/dashboards/overview/dashboard_panels.ts
Show resolved
Hide resolved
I reviewed the pull request changes and there is code that is doing other things that are not related to display the callout. Maybe you could mention these changes into the description of the pull request to be aware of these too. |
…s-no-data-in-the-vulnerabilities-index
…s-no-data-in-the-vulnerabilities-index
|
|
|
asteriscos
deleted the
fix/6166-show-call-out-warning-when-there-is-no-data-in-the-vulnerabilities-index
branch
December 1, 2023 18:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a vulnerability index data check and displays a warning call-out in case the index does not exist or there is no data in it. This applies to both the Dashboard tab and the Inventory tab.
This pull request also fixes the following changes:
@timestamp
is used instead ofevent.create
in the "Accumulation of the most detected vulnerabilities" visualizationevent.create
in inventoryvulnerability.severity
fields.os.full
fieldIssues Resolved
Evidence
Health check warning message when no indices match vulnerability index pattern
Vulnerability detection dashboard when no indices match vulnerability index pattern
Vulnerability detection inventory when no indices match vulnerability index pattern
Health check when the vulnerability index exists
Vulnerability detector dashboard when the vulnerability index exists, but mapping is wrong
Vulnerability detector dashboard when the vulnerability index exists and mapping is correct
Vulnerability detector inventory when the vulnerability index exists and mapping is correct
Test
Before remember to create the mapping of port
9200:9200
inosd1
in thedev.yml
Check List
yarn test:jest