Remove application menu in the IT Hygiene #6176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove application menu - Add link to Endpoint Summary - Refactor the responsive of header button using styles instead of controlled by JS - Changed the icon of Endpoint Summary application
UI Test
Details 🟢 With a large window size and side menu is opened and locked, the header of the IT Hygiene application should display buttons with icon and textChrome - 🟢 🟢 With no large window size and side menu is opened and locked, the header of IT Hygiene application should display buttons only icon with a tooltip when hooveringChrome - 🟢 🟢 With a large window size and side menu closed, the header of the IT Hygiene application should display buttons with icon and textChrome - 🟢 🟢 With no large window size and side menu is closed, the header of the IT Hygiene application should display buttons only icon with a tooltip when hooveringChrome - 🟢 🟢 The Endpoint Summary header button in the IT Hygiene application should redirect to Endpoint SummaryChrome - 🟢 |
|
|
|
asteriscos
approved these changes
Dec 1, 2023
1 task
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the application menu in the IT Hygiene and add a button to redirect to Endpoints Summary.
Changes:
Issues Resolved
#6169
Evidence
The side menu is open and locked. Windows size not large.
The side menu is open and locked. Windows size large.
The side menu is closed. Windows size not large.
The side menu is closed. Windows size large.
Hot to lock the side menu
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Details
⚫ With a large window size and side menu is opened and locked, the header of the IT Hygiene application should display buttons with icon and text
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ With no large window size and side menu is opened and locked, the header of IT Hygiene application should display buttons only icon with a tooltip when hoovering
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ With a large window size and side menu closed, the header of the IT Hygiene application should display buttons with icon and text
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ With no large window size and side menu is closed, the header of the IT Hygiene application should display buttons only icon with a tooltip when hoovering
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ The Endpoint Summary header button in the IT Hygiene application should redirect to Endpoint Summary
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest