Improve Agents preview page load when there are no agents #6185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asteriscos
requested changes
Dec 5, 2023
There was a problem hiding this comment.
CR: ❌ Changelog entry should be placed in fixed. As it's not something new o a change in the behaviour of a feature.
Test: ✔️
The agent's dashboard is not seen as it loads.
Overview -> Register Agent
Peek.2023-12-05.18-44.mp4
Agents initial load
Peek.2023-12-05.18-45.mp4
plugins/main/public/controllers/agent/components/agents-preview.js
Outdated
Show resolved
Hide resolved
|
asteriscos
approved these changes
Dec 7, 2023
yenienserrano
approved these changes
Dec 7, 2023
asteriscos
deleted the
enhancement/6175/improve-agent-preview-page-load-when-there-is-are-agents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When there are no registered agents and the
Agents previewpage is loaded, the component with the dashboard and the list of agents is always shown first for a moment, and then the component to register an agent is displayed. This PR fixes in the case where there are no registered agents so that the component with the dashboard and the list is not shown first but directly displays the component to register an agent.Issues Resolved
#6175
Evidence
With no registered Agents: Go to Modules -> Modules directory. Click
Add agentWith no registered Agents: Go to Agents from another page
With registered Agents: Go to Agents from another page and click
Deploy new agentTest
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Add agentDeploy new agentDetails
⚫ With no registered Agents: Go to Modules -> Modules directory. Click `Add agent`
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ With no registered Agents: Go to Agents from another page
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ With registered Agents: Go to Agents from another page and click `Deploy new agent`
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest