Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links las registered agent and agent most active #6244

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Fix links las registered agent and agent most active #6244

merged 3 commits into from
Dec 21, 2023

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Dec 21, 2023 •
edited
Loading

Description

Fix the links of the last registered agent and the most active agent.

Issues Resolved

Evidence

image

Test

  1. Navigate to summary endpoints
  2. Test the links of the last registered agent and the most active agent, if you don't have agents in those fields it should not be a link. (the application to which you are redirected should be it hygiene)

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano requested a review from a team as a code owner December 21, 2023 11:42
@yenienserrano yenienserrano self-assigned this Dec 21, 2023
@yenienserrano yenienserrano mentioned this pull request Dec 21, 2023
Closed
19 tasks
asteriscos
asteriscos approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

image

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.42% ( 186 / 868 )
Branches 17.99% ( 79 / 439 )
Functions 14.22% ( 36 / 253 )
Lines 21.65% ( 183 / 845 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.68% ( 171 / 223 )
Branches 57.57% ( 57 / 99 )
Functions 61.7% ( 29 / 47 )
Lines 76.68% ( 171 / 223 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.08% ( 4160 / 34437 )
Branches 8.18% ( 1893 / 23129 )
Functions 11.54% ( 944 / 8179 )
Lines 12.25% ( 4047 / 33028 )

@JuanGarriuz JuanGarriuz requested review from JuanGarriuz and removed request for JuanGarriuz December 21, 2023 12:22
Tostti
Tostti approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Test ✅
CR ✅

LGTM

@asteriscos asteriscos merged commit 662ce20 into 4.8.0 Dec 21, 2023
4 checks passed
@asteriscos asteriscos deleted the fix/wd-94-fix-links-last-registered-agent-and-most-active branch December 21, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tostti Tostti Tostti approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yenienserrano @asteriscos @Tostti