Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The check update button does not show the date of the last scan #6328

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jan 16, 2024

Description

Fixed the date of the last update scan in the tooltip of the check updates button.

Fixed the menu overlay with update notification when opening and closing a flyout.

Issues Resolved

Evidence

image

OpenSearch.Dashboards.-.Google.Chrome.2024-01-16.18-13-35.mp4

Test

  1. Navigate to 'Server APIs'
  2. Check the date in the check updates tooltip and if you click it should change.

You must have the update notification available.

  1. Navigate to 'Security'
  2. Click on 'Create user'
  3. Close flyout
  4. The notification should look complete

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano linked an issue Jan 16, 2024 that may be closed by this pull request
@yenienserrano yenienserrano self-assigned this Jan 16, 2024
@yenienserrano yenienserrano marked this pull request as ready for review January 17, 2024 09:13
@yenienserrano yenienserrano requested a review from a team as a code owner January 17, 2024 09:13
@lucianogorza lucianogorza self-requested a review January 17, 2024 17:11
@lucianogorza
Copy link
Contributor

lucianogorza commented Jan 17, 2024

CR 🟢

Test 🟢

Last update tooltip

image

Published date

image

Menu overlay with update notification when opening and closing a flyout

screen-capture.webm

lucianogorza
lucianogorza previously approved these changes Jan 17, 2024
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jbiset jbiset self-requested a review January 18, 2024 11:33
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.18% ( 186 / 878 )
Branches 17.99% ( 79 / 439 )
Functions 14% ( 36 / 257 )
Lines 21.4% ( 183 / 855 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 57.42% ( 58 / 101 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.21% ( 4203 / 34419 )
Branches 8.26% ( 1911 / 23121 )
Functions 11.71% ( 958 / 8176 )
Lines 12.38% ( 4088 / 33011 )

Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test UI 🟢

Evidence

image

Evidence.webm

@asteriscos asteriscos merged commit c4d8f1b into 4.8.0 Jan 18, 2024
4 checks passed
@asteriscos asteriscos deleted the fix/6308-the-check-update-button-does-not-show-the-date-of-the-last-scan branch January 18, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The check update button does not show the date of the last scan
4 participants