Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unnecessary scroll in Vulnerability inventory #6345

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Fix unnecessary scroll in Vulnerability inventory #6345

merged 5 commits into from
Jan 19, 2024

Conversation

yenienserrano
Copy link
Member

Description

Fixes the unnecessary scrolling that occurs when you search for something that results in 1 page and then return to a multi-page result.

Issues Resolved

#6324

Evidence

video.mp4

Test

  1. Navigate to 'Vunerability/Inventory'
  2. Filter table to have 1 page of results
  3. Remove filter to have more than 1 page of results
  4. Should not be able to scroll the page

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano requested a review from a team as a code owner January 19, 2024 10:10
@yenienserrano yenienserrano linked an issue Jan 19, 2024 that may be closed by this pull request
Remove scroll from vulnerabilities inventory table #6324
Closed
@yenienserrano yenienserrano self-assigned this Jan 19, 2024
asteriscos
asteriscos previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Firefox: 🟢
Peek 2024-01-19 11-56

Chrome: 🟢
Peek 2024-01-19 11-54

asteriscos
asteriscos previously approved these changes Jan 19, 2024
View reviewed changes
@jbiset jbiset self-requested a review January 19, 2024 12:10
jbiset
jbiset previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

Chrome

Evidence_Chrome.webm

Firefox

Evidence_Firefox.webm

@asteriscos asteriscos dismissed stale reviews from jbiset and themself via 72c53bc January 19, 2024 13:14
asteriscos
asteriscos previously approved these changes Jan 19, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.18% ( 186 / 878 )
Branches 17.99% ( 79 / 439 )
Functions 14% ( 36 / 257 )
Lines 21.4% ( 183 / 855 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 57.42% ( 58 / 101 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.21% ( 4203 / 34420 )
Branches 8.26% ( 1911 / 23123 )
Functions 11.71% ( 958 / 8176 )
Lines 12.38% ( 4088 / 33012 )

@asteriscos asteriscos merged commit c1a2039 into 4.8.0 Jan 19, 2024
4 checks passed
@asteriscos asteriscos deleted the 6324-remove-scroll-from-vulnerabilities-inventory-table branch January 19, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbiset jbiset jbiset approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove scroll from vulnerabilities inventory table
3 participants
@yenienserrano @asteriscos @jbiset