Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated help menu #6374

Merged
merged 4 commits into from
Jan 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ All notable changes to the Wazuh app project will be documented in this file.
- Fixed unnecessary scrolling in Vulnerability Inventory table [#6345](https://github.com/wazuh/wazuh-dashboard-plugins/pull/6345)
- Fixed wrong value at server stat Archives queue usage [#6342](https://github.com/wazuh/wazuh-dashboard-plugins/pull/6342)
- Fixed the inventory data table when maximized and the docked menu [#6344](https://github.com/wazuh/wazuh-dashboard-plugins/pull/6344)
- Fixed the help menu, to be consistent and avoid duplication [#6374](https://github.com/wazuh/wazuh-dashboard-plugins/pull/6374)

### Removed

Expand Down
5 changes: 1 addition & 4 deletions plugins/main/public/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ import { updateCurrentPlatform } from './redux/actions/appStateActions';
import { WzAuthentication, loadAppConfig } from './react-services';

import { getAngularModule, getHttp } from './kibana-services';
import { addHelpMenuToAppChrome } from './utils';

const app = getAngularModule();

Expand Down Expand Up @@ -78,7 +77,7 @@ app.run([
.then(item => {
store.dispatch(updateCurrentPlatform(item));
})
.catch(() => {});
.catch(() => { });

// Init the process of refreshing the user's token when app start.
checkPluginVersion().finally(WzAuthentication.refresh);
Expand All @@ -102,8 +101,6 @@ app.run(function ($rootElement) {
<react-component name="WzUpdatesNotification" props=""></react-component>
</div>`);

// Add plugin help links as extension to plugin platform help menu
addHelpMenuToAppChrome();

// Bind deleteExistentToken on Log out component.
$('.euiHeaderSectionItem__button, .euiHeaderSectionItemButton').on(
Expand Down
52 changes: 0 additions & 52 deletions plugins/main/public/utils/add_help_menu_to_app.tsx

This file was deleted.

2 changes: 0 additions & 2 deletions plugins/main/public/utils/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export { checkPluginVersion } from './check-plugin-version';

export { addHelpMenuToAppChrome } from './add_help_menu_to_app';
Loading