-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid force check updates when user logins #6375
Merged
Tostti
merged 3 commits into
4.8.0
from
enhancement/6308-avoid-force-check-updates-when-user-logins
Jan 30, 2024
Merged
Avoid force check updates when user logins #6375
Tostti
merged 3 commits into
4.8.0
from
enhancement/6308-avoid-force-check-updates-when-user-logins
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
chantal-kelm
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tostti
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test ✅
CR ✅
LGTM
Tostti
deleted the
enhancement/6308-avoid-force-check-updates-when-user-logins
branch
January 30, 2024 14:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents checking for updates with the force_query parameter set to true upon user login. Consequently, the Wazuh API will now return available updates without querying the CTI Service.
Issues Resolved
#6308
Evidence
query_api
: Determines whether the Check Updates plugin retrieves data from the Wazuh API or from a saved object.force_query
: Whenquery_api
is set to true, it determines whether the Wazuh API internally obtains the data or fetches it from the CTI Service.After user logins
Server APIs page
Check updates button
Update Check updates button tooltip
Test
/api/wazuh-check-updates/updates?query_api=true&force_query=false
Indexer/dashboard management -> Server APIs
and check de request:/api/wazuh-check-updates/updates?query_api=false&force_query=false
Check updates
button and check the request:/api/wazuh-check-updates/updates?query_api=true&force_query=true
Check List
yarn test:jest