Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor style fixes in light and dark mode #6489

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Minor style fixes in light and dark mode #6489

merged 2 commits into from
Mar 8, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Mar 8, 2024 •
edited by Desvelao
Loading

Description

This pull request fixes the style of the euiPage component background color and overview icons for both light and dark theme.

Issues Resolved

Evidence

Light theme

image

Dark theme

image

Test

  • Check the Overview page looks like the images provided.
  • The euiPage component shouldn't have the native grey color in the light theme.

Check List

  • All tests pass
    • yarn test:jest
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Mar 8, 2024
@asteriscos asteriscos linked an issue Mar 8, 2024 that may be closed by this pull request
Minor style improvements #6483
Closed
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.89% ( 186 / 890 )
Branches 17.91% ( 79 / 441 )
Functions 13.89% ( 36 / 259 )
Lines 21.1% ( 183 / 867 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@JuanGarriuz JuanGarriuz self-requested a review March 8, 2024 10:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Main plugin code coverage (Jest) test % values
Statements 12.13% ( 4210 / 34699 )
Branches 8.2% ( 1907 / 23256 )
Functions 11.57% ( 957 / 8267 )
Lines 12.3% ( 4098 / 33300 )

JuanGarriuz
JuanGarriuz approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✔️

Test ✔️

Evidence

image
image

@Desvelao
Copy link
Member

Desvelao commented Mar 8, 2024

Test

image

image

Desvelao
Desvelao approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asteriscos asteriscos merged commit d1772f9 into 4.8.0 Mar 8, 2024
4 checks passed
@asteriscos asteriscos deleted the fix/overview-dark-and-light-styles-6483 branch March 8, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

@Desvelao Desvelao Desvelao approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor style improvements
3 participants
@asteriscos @Desvelao @JuanGarriuz