Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change PDF report year number to 2024 #6492

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Change PDF report year number to 2024 #6492

merged 3 commits into from
Mar 8, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Mar 8, 2024 •
edited
Loading

Description

This PR changes PDF report year number to 2024.

Issues Resolved

Evidence

image

Test

  • Verify the PDF reports have 2024 as the year number

Check List

  • All tests pass
    • yarn test:jest
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Mar 8, 2024
@asteriscos asteriscos linked an issue Mar 8, 2024 that may be closed by this pull request
Update PDF report year number #6491
Closed
1 task
@JuanGarriuz JuanGarriuz self-requested a review March 8, 2024 13:43
JuanGarriuz
JuanGarriuz previously approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

yenienserrano
yenienserrano previously approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅

JuanGarriuz
JuanGarriuz previously approved these changes Mar 8, 2024
View reviewed changes
@asteriscos asteriscos dismissed stale reviews from JuanGarriuz and yenienserrano via 1aae3ca March 8, 2024 13:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.89% ( 186 / 890 )
Branches 17.91% ( 79 / 441 )
Functions 13.89% ( 36 / 259 )
Lines 21.1% ( 183 / 867 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Main plugin code coverage (Jest) test % values
Statements 12.13% ( 4210 / 34699 )
Branches 8.2% ( 1907 / 23256 )
Functions 11.57% ( 957 / 8267 )
Lines 12.3% ( 4098 / 33300 )

@asteriscos asteriscos merged commit b54d12c into 4.8.0 Mar 8, 2024
4 checks passed
@asteriscos asteriscos deleted the change/report-pdf-year-number-6491 branch March 8, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

@yenienserrano yenienserrano yenienserrano left review comments

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update PDF report year number
3 participants
@asteriscos @yenienserrano @JuanGarriuz