Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement embeddable dashboard on NIST 800-53 #6515

Merged

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Mar 14, 2024

Description

This pull request replaces the Dashboard tab on NIST 800-53 application.

Issues Resolved

#6514

Evidence

image
image
image

Test

Go to NIST 800-53 > Dashboard:

Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking.
The visualizations have to be updated according to the filters applied in the searchbar.
The visualizations have to be updated when a search is performed in the searchbar.
If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered.
If there is SampleData, the corresponding SampleData message must appear.
If an agent is pinned, the views must be updated and changed to the agent view, if applicable.
Check filter behavior with respect to hide alerts, allow agents and filter order.

Go to NIST 800-53 > Controls
Check the requirements filters on the on the left side filters the requirements on the right side
Click on the requirement to open the flyout and interact with the search bar and links, they should work as expected. The search should take into account optionally the allowed agents and the hide manager alerts plugin setting if enabled.
In the details flyout click on the show on dashboard and events links, they should display this tabs with a filter related to the selected requirement
The link on the flyout table should redirect to Endpoint Summary and Rules respectively

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao self-assigned this Mar 14, 2024
@Desvelao Desvelao linked an issue Mar 14, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.37% ( 397 / 875 )
Branches 41.31% ( 157 / 380 )
Functions 43.83% ( 135 / 308 )
Lines 45.61% ( 395 / 866 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 10.8% ( 3751 / 34716 )
Branches 7.27% ( 1653 / 22731 )
Functions 10.5% ( 870 / 8282 )
Lines 10.95% ( 3645 / 33273 )

@Desvelao Desvelao marked this pull request as ready for review May 10, 2024 10:49
@JuanGarriuz JuanGarriuz self-requested a review May 10, 2024 13:15
@yenienserrano
Copy link
Member

yenienserrano commented May 10, 2024

Test

Go to NIST 800-53 > Dashboard:

  • Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking.
Details image
  • The visualizations have to be updated according to the filters applied in the searchbar.
Details image
  • The visualizations have to be updated when a search is performed in the searchbar.
Details image
  • If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered.
Details image
  • If there is SampleData, the corresponding SampleData message must appear.
Details image
  • If an agent is pinned, the views must be updated and changed to the agent view, if applicable.
Details image
  • Check filter behavior with respect to hide alerts, allow agents and filter order.
Details image

Go to NIST 800-53 > Controls

  • Check the requirements filters on the on the left side filters the requirements on the right side
Details image
  • Click on the requirement to open the flyout and interact with the search bar and links, they should work as expected.
Details image
  • The search should take into account optionally the allowed agents and the hide manager alerts plugin setting if enabled.
Details image
  • In the details flyout click on the show on dashboard and events links, they should display this tabs with a filter related to the selected requirement
Details image image image
  • The link on the flyout table should redirect to Endpoint Summary and Rules respectively
Details image image ![Uploading image.png…]()

yenienserrano
yenienserrano previously approved these changes May 10, 2024
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

@JuanGarriuz
Copy link
Member

Test

Dashboards

Grabacion.2024-05-10.135552.mp4

image

Controls

Grabacion.2024-05-10.135552.mp4

image

JuanGarriuz
JuanGarriuz previously approved these changes May 13, 2024
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!

@asteriscos asteriscos merged commit 510714d into 4.9.0 May 13, 2024
1 check passed
@asteriscos asteriscos deleted the feat/6514-implement-embeddable-dashboard-on-nist-800-53 branch May 13, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remove discover] Implement embeddable dashboard on NIST 800-53 module
4 participants