[Remove discover] Implement embeddable dashboard on Virustotal module #6525

jbiset · 2024-03-15T15:31:14Z

Description

This pull request implement the embeddable dashboard on Virustotal -> dashboard tab and deprecate any use of kibana-integrations components.

Issues Resolved

[Remove discover] Implement embeddable dashboard on Virustotal module #6511

Evidence

Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking.

Evidence1.webm

The visualizations have to be updated according to the filters applied in the searchbar.

Evidence2.webm

The visualizations have to be updated when a search is performed in the searchbar.

Evidence3.webm

If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered.

If there is SampleData, the corresponding SampleData message must appear.

If an agent is pinned, the views must be updated and changed to the agent view, if applicable.

Evidence6.webm

Check filter behavior with respect to hide alerts, allow agents and filter order.

Test

Go to Virustotal and check the following:

Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking.
The visualizations have to be updated according to the filters applied in the searchbar.
The visualizations have to be updated when a search is performed in the searchbar.
If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered.
If there is SampleData, the corresponding SampleData message must appear.
If an agent is pinned, the views must be updated and changed to the agent view, if applicable.
Check filter behavior with respect to hide alerts, allow agents and filter order.

Check List

All tests pass
- yarn test:jest
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

…ashboard_on_virustotal_module

…r to commons components

github-actions · 2024-04-17T12:55:34Z

Wazuh Core plugin code coverage (Jest) test	%	values
Statements	45.37%	( 397 / 875 )
Branches	41.31%	( 157 / 380 )
Functions	43.83%	( 135 / 308 )
Lines	45.61%	( 395 / 866 )

github-actions · 2024-04-17T12:55:45Z

Wazuh Check Updates plugin code coverage (Jest) test	%	values
Statements	76.44%	( 172 / 225 )
Branches	58.65%	( 61 / 104 )
Functions	61.7%	( 29 / 47 )
Lines	76.44%	( 172 / 225 )

github-actions · 2024-04-17T13:00:08Z

Main plugin code coverage (Jest) test	%	values
Statements	10.79%	( 3751 / 34738 )
Branches	7.26%	( 1653 / 22752 )
Functions	10.49%	( 870 / 8287 )
Lines	10.94%	( 3645 / 33294 )

…ashboard_on_virustotal_module

…ay to get pinned agent

plugins/main/public/components/common/hocs/withPinnedAgent.tsx

…ashboard_on_virustotal_module

JuanGarriuz · 2024-04-23T09:46:22Z

Test

Go to Virustotal and check the following:

Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking.

20240423-0940-49.2092540.mp4

The visualizations have to be updated according to the filters applied in the searchbar.

The visualizations have to be updated when a search is performed in the searchbar.

If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered.

If there is SampleData, the corresponding SampleData message must appear.

If an agent is pinned, the views must be updated and changed to the agent view, if applicable.

Check filter behavior with respect to hide alerts, allow agents and filter order.

JuanGarriuz

LGTM!!

…ashboard_on_virustotal_module

plugins/main/public/components/common/modules/modules-defaults.tsx

...ponents/common/data-source/pattern/alerts/alerts-virustotal/alerts-virustotal-data-source.ts

plugins/main/public/components/overview/virustotal/dashboard/dashboard.tsx

yenienserrano · 2024-04-23T20:13:42Z

Go to Virustotal and check the following:

Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking.

Details

The visualizations have to be updated according to the filters applied in the searchbar.

Details

The visualizations have to be updated when a search is performed in the searchbar.

Details

If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered.

Details

If there is SampleData, the corresponding SampleData message must appear.

Details

If an agent is pinned, the views must be updated and changed to the agent view, if applicable.

Details

Check filter behavior with respect to hide alerts, allow agents and filter order.

Details

plugins/main/public/components/overview/virustotal/dashboard/dashboard.tsx

…ashboard_on_virustotal_module

…struction

… allows you to affect all the filters in the search bar

…ve duplicate filters

…leted wz-discover on SearchBar wrapper

yenienserrano

LGTM

JuanGarriuz

LGTM!!

…#6525) * Migrated visualizations, added loadings and messages * Fixed warning for expected a single ReactElement * Added new virustotal data source. Changed NoResults and LoadingSpinner to commons components * Fixed Events tab * Integrated pinned agent functionality based on data source * Added timeRange to dashboard useEffect dependencies and changed the way to get pinned agent * Deleted unused component * Changed AlertsVirustotalDataSource import in modules-defaults * Fixed error message * DashboardByRenderer timeRange params replaced by searchBarProps deconstruction * Added wz-discover hide-filter-control classes to hide the button that allows you to affect all the filters in the search bar * Removed unnecessary virus total in Filters tab in common data to remove duplicate filters * Removed unused getImplicitPinnedAgent in modules-helper * Added dateRange param to fetchData in dashboard useEffect * Improved AlertsVirustotalDataSource import in modules-defaults and deleted wz-discover on SearchBar wrapper

* Moved mitre intelligence to a subfolder * fix imports * moved mitre framework * fix framework imports * Changed dashboard * updated snapshots * Fixed typo * Added pinned agent mode * Changed mitre dashboard * Fix framework tab * Add mitre data source * Change framework tab class components to functional components * Added date picker in search bar * Add aggregattions to search * Add columns definition in data grid * Fix cluster disabled error on filter * Add receive filter manager like prop * Create generic components to reuse in discover * Add mitre attack data source * Create flyout discover * Refactor mitre with data source * Add default fetch filters * Linter in wz-discover * Create component to reuse in discover * Add expanded techniques row inner component * Apply initial fetch filters on flyout * Linter on mitre module * Fix cluster filter * Fix UI styles * Add redirect links and apply filters links * Update CHANGELOG * Remove unused code and imports * Fix table headers and cell links * Move mitre lib to react-services * Fix files with prettier * Signed commit * [Remove discover] Implement embeddable dashboard on server management cluster module (#6561) * Migrated Server Management Cluster to embeddables without cluster controller * Fixed width of Cluster Configuration section * Rendering conditions are adjusted and clean code * Deleted controller and visualization monitoring files * Integrated data-source implementation * Fixed configuration_cards itemsList, the code is improved and unnecessary code is removed * Added HOC withGuardAsync * Changed the source of clusterEnabled information to that provided by the API * Changed ClusterOverview component class to functional and fixed error on checkClusterIsEnabledAndRunning * Added more dependencies in useEffect on Cluster Dashboard * Added error handling to cluster-disabled component * Fixed alert.timestamp field on SampleData * Remove discover - Implement embeddable dashboard on statistics module (#6542) * Migrated visualizations to embeddables * Changed searchbar and node selector * Cleaned dashboard obsolete code * Added selectedNodeFilter * Integrated new data source on statistics * Fixed statistics index without data. * Added apiName filter * Fixed nodeName filter when a node is selected in cluster mode * Added No results message, fixed allow agents filters on request and cleaned obsolete code * Changed condition of apiName filter, validation of statistics-data-source-repository and abstracted behavior between DashboardListenerEngineStatistics and DashboardAnalysisEngineStatistics * Deleted unused use-build-statistics-visualizations hook * Fixed information message depending on active tab * Added withUserAuthorizationPrompt to add protection with the user permissions check * remove(statistics): unused message definitions * Deleted unused index.ts file on cluster integration-files visualizations --------- Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> * Fix changelog entries (#6612) * changelog: fix entries * Change enrollment.dns changelog entry --------- Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> * Remove AngularJS component click-action.js (#6613) * remove click-action.js * update changelog * Update changelog --------- Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> * Refactor settings angularJS controller (#6580) * Create settings component * Parcial refactor into react component * Remove angularJS controller * Remove unnecessary properties * Add changelog * fix: category parameter to preselect the app category settings on App Settings from Statistics * Remove optional chaining operator --------- Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> * Fix mitre columns error in techniques on hover * Hide remove filters on search bar * Use not global time filter and query in search bar * Fix filters in visualizations * Implement journald log collection feature (#6572) * Added tab * Add journald tab * Added changes to imposter * journald values filters table * Update changelog and redesign filters table * Fixed styles * Fixed hardcode bug * Added filters groups * Change to an accordion render * Added helps-link * Added changelog * Fix changelog and message popover improve * Update configuration-setting imports * Fix macOS log title * resolve comments * Fixed info euitext render and header no render in journald tab * Add verification to mac and journald agents and add condition to journald --------- Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> * Remove global filter manager from common-data * Fix date range parser on requests * Fix error when remove query saved * Add timestamp formatted in events data grid * [Remove discover] Implement embeddable dashboard on Virustotal module (#6525) * Migrated visualizations, added loadings and messages * Fixed warning for expected a single ReactElement * Added new virustotal data source. Changed NoResults and LoadingSpinner to commons components * Fixed Events tab * Integrated pinned agent functionality based on data source * Added timeRange to dashboard useEffect dependencies and changed the way to get pinned agent * Deleted unused component * Changed AlertsVirustotalDataSource import in modules-defaults * Fixed error message * DashboardByRenderer timeRange params replaced by searchBarProps deconstruction * Added wz-discover hide-filter-control classes to hide the button that allows you to affect all the filters in the search bar * Removed unnecessary virus total in Filters tab in common data to remove duplicate filters * Removed unused getImplicitPinnedAgent in modules-helper * Added dateRange param to fetchData in dashboard useEffect * Improved AlertsVirustotalDataSource import in modules-defaults and deleted wz-discover on SearchBar wrapper * [Remove discover] Implement embeddable dashboard on Threat Hunting module (#6486) * Migrated visualizations to embeddables * Added withPinnedAgent HOC * Added dashboard update mechanism depending on whether or not an agent has been pinned * Pinned agent visualization definitions are migrated and aesthetic adjustments are made * The interaction was added to the KPIs, the links to the lower table were added, as well as the change of columns when an agent is set * Integrated new data source on Threat Hunting module * DiscoverNoResults and LoadingSpinner components are replaced with common components * Clean code and fixed dashboards conditions * Improved condition for rendering the dashboard and SampleData message * Removed unnecessary general/threat hunting in tabFilters in common data to remove duplicate filters * Removed unused getImplicitPinnedAgent in modules-helper * Added dateRange param to fetchData in dashboard useEffect, added wz-discover hide-filter-control classes to hide the button that allows you to affect all the filters in the search bar and use searchbarProps deconstruction * Deleted unnecessary wz-discover class on SearchBar wrapper * Changed Threat Hunting columns file name * Deleted unused imports in modules-helper --------- Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com> Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> * Renamed virus total data source * Change order fixed filters virus total * Clean dashboard code --------- Co-authored-by: Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Maximiliano Ibarra <6089438+Machi3mfl@users.noreply.github.com> Co-authored-by: Julio César Biset <43619595+jbiset@users.noreply.github.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com> Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>

Migrated visualizations, added loadings and messages

2c0bd7d

jbiset self-assigned this Mar 15, 2024

jbiset linked an issue Mar 15, 2024 that may be closed by this pull request

[Remove discover] Implement embeddable dashboard on Virustotal module #6511

Closed

18 tasks

jbiset and others added 5 commits March 15, 2024 12:41

Merge branch '4.9.0' into 6511-remove_discover_implement_embeddable_d…

068f85a

…ashboard_on_virustotal_module

Fixed warning for expected a single ReactElement

27c0866

Merge branch '4.9.0' into 6511-remove_discover_implement_embeddable_d…

627324a

…ashboard_on_virustotal_module

Added new virustotal data source. Changed NoResults and LoadingSpinne…

60e38f7

…r to commons components

Fixed Events tab

6b060cf

jbiset and others added 2 commits April 17, 2024 12:30

Merge branch '4.9.0' into 6511-remove_discover_implement_embeddable_d…

8010132

…ashboard_on_virustotal_module

Integrated pinned agent functionality based on data source

bd2a3fe

jbiset marked this pull request as ready for review April 18, 2024 18:57

Added timeRange to dashboard useEffect dependencies and changed the w…

ddcc3f9

…ay to get pinned agent

JuanGarriuz reviewed Apr 19, 2024

View reviewed changes

plugins/main/public/components/common/hocs/withPinnedAgent.tsx Outdated Show resolved Hide resolved

jbiset added 2 commits April 19, 2024 09:23

Deleted unused component

aced1de

Merge branch '4.9.0' into 6511-remove_discover_implement_embeddable_d…

e0899ca

…ashboard_on_virustotal_module

JuanGarriuz previously approved these changes Apr 23, 2024

View reviewed changes

Merge branch '4.9.0' into 6511-remove_discover_implement_embeddable_d…

e726750

…ashboard_on_virustotal_module

yenienserrano reviewed Apr 23, 2024

View reviewed changes

yenienserrano reviewed Apr 24, 2024

View reviewed changes

plugins/main/public/components/overview/virustotal/dashboard/dashboard.tsx Outdated Show resolved Hide resolved

jbiset and others added 5 commits April 24, 2024 15:10

Merge branch '4.9.0' into 6511-remove_discover_implement_embeddable_d…

8fa4bd0

…ashboard_on_virustotal_module

Changed AlertsVirustotalDataSource import in modules-defaults

cdec2ef

Fixed error message

3d724de

DashboardByRenderer timeRange params replaced by searchBarProps decon…

03334ab

…struction

Added wz-discover hide-filter-control classes to hide the button that…

28a97e9

… allows you to affect all the filters in the search bar

jbiset dismissed JuanGarriuz’s stale review via 28a97e9 April 24, 2024 18:42

jbiset added 4 commits April 24, 2024 15:50

Removed unnecessary virus total in Filters tab in common data to remo…

172c1a1

…ve duplicate filters

Removed unused getImplicitPinnedAgent in modules-helper

05fe91d

Added dateRange param to fetchData in dashboard useEffect

8034905

Improved AlertsVirustotalDataSource import in modules-defaults and de…

c8e7073

…leted wz-discover on SearchBar wrapper

yenienserrano approved these changes Apr 24, 2024

View reviewed changes

JuanGarriuz approved these changes Apr 25, 2024

View reviewed changes

asteriscos merged commit d8a6b29 into 4.9.0 Apr 25, 2024
1 check passed

asteriscos deleted the 6511-remove_discover_implement_embeddable_dashboard_on_virustotal_module branch April 25, 2024 12:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Remove discover] Implement embeddable dashboard on Virustotal module #6525

[Remove discover] Implement embeddable dashboard on Virustotal module #6525

jbiset commented Mar 15, 2024 •

edited

Loading

github-actions bot commented Apr 17, 2024

github-actions bot commented Apr 17, 2024

github-actions bot commented Apr 17, 2024

JuanGarriuz commented Apr 23, 2024 •

edited

Loading

JuanGarriuz left a comment

yenienserrano commented Apr 23, 2024 •

edited

Loading

yenienserrano left a comment

JuanGarriuz left a comment

[Remove discover] Implement embeddable dashboard on Virustotal module #6525

[Remove discover] Implement embeddable dashboard on Virustotal module #6525

Conversation

jbiset commented Mar 15, 2024 • edited Loading

Description

Issues Resolved

Evidence

Test

Check List

github-actions bot commented Apr 17, 2024

github-actions bot commented Apr 17, 2024

github-actions bot commented Apr 17, 2024

JuanGarriuz commented Apr 23, 2024 • edited Loading

Test

JuanGarriuz left a comment

Choose a reason for hiding this comment

yenienserrano commented Apr 23, 2024 • edited Loading

yenienserrano left a comment

Choose a reason for hiding this comment

JuanGarriuz left a comment

Choose a reason for hiding this comment

jbiset commented Mar 15, 2024 •

edited

Loading

JuanGarriuz commented Apr 23, 2024 •

edited

Loading

yenienserrano commented Apr 23, 2024 •

edited

Loading