Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overview AngularJS controllers #6594

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Apr 17, 2024

Description

This pull request removes the overview AngularJS controllers.

Issues Resolved

Evidence

image image image

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
The overview must be rendered correctly
the navigation to the different modules should work as expected.
the tab tabView _g _a and if applicable the agentId must appear in the URL.
Modules must render the corresponding dashboards whether or not they have a pinned agent.

Details

⚫ The overview must be rendered correctly

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ the navigation to the different modules should work as expected.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ the Tab TabView _g _a and if applicable the agentId must appear in the URL.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Modules must render the corresponding dashboards whether or not they have a pinned agent.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Apr 17, 2024
@yenienserrano yenienserrano linked an issue Apr 17, 2024 that may be closed by this pull request
@yenienserrano yenienserrano marked this pull request as ready for review May 3, 2024 15:42
@lucianogorza lucianogorza self-requested a review May 3, 2024 16:26
@jbiset jbiset self-requested a review May 3, 2024 16:43
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test UI 🟢

Test Chrome Firefox Safari
The overview must be rendered correctly 🟢 🟢
The navigation to the different modules should work as expected and modules must render the corresponding dashboards whether or not they have a pinned agent. 🟢 🟢
the tab tabView _g _a and if applicable the agentId must appear in the URL. 🟢 🟢

Details

🟢 The overview must be rendered correctly

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 The navigation to the different modules should work as expected. And modules must render the corresponding dashboards whether or not they have a pinned agent

Chrome - 🟢

Evidence_1_Chrome.webm

Firefox - 🟢

Evidence_1_Firefox.webm

Safari - ⚫

🟢 the Tab TabView _g _a and if applicable the agentId must appear in the URL.

Chrome - 🟢

image

URL:

https://0.0.0.0:5601/app/threat-hunting#/overview/?tab=general&tabView=panels&_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-24h,to:now))&_a=(filters:!(('$state':(store:appState),meta:(alias:!n,controlledBy:cluster-manager,disabled:!f,index:'wazuh-alerts-*',key:cluster.name,negate:!f,params:(query:wazuh),removable:!f,type:phrase),query:(match:(cluster.name:(query:wazuh,type:phrase)))),('$state':(store:appState),meta:(alias:!n,controlledBy:pinned-agent,disabled:!f,index:'wazuh-alerts-*',key:agent.id,negate:!f,params:(query:'001'),type:phrase),query:(match:(agent.id:(query:'001',type:phrase)))),('$state':(store:appState),meta:(alias:!n,disabled:!f,index:'wazuh-alerts-*',key:agent.name,negate:!f,params:(query:Windows),type:phrase),query:(match_phrase:(agent.name:Windows)))),language:kuery,query:'')&agentId=001

Firefox - 🟢

image

URL:

https://0.0.0.0:5601/app/threat-hunting#/overview/?tab=general&tabView=panels&_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-24h,to:now))&_a=(filters:!(('$state':(store:appState),meta:(alias:!n,controlledBy:cluster-manager,disabled:!f,index:'wazuh-alerts-*',key:cluster.name,negate:!f,params:(query:wazuh),removable:!f,type:phrase),query:(match:(cluster.name:(query:wazuh,type:phrase)))),('$state':(store:appState),meta:(alias:!n,controlledBy:pinned-agent,disabled:!f,index:'wazuh-alerts-*',key:agent.id,negate:!f,params:(query:'001'),type:phrase),query:(match:(agent.id:(query:'001',type:phrase)))),('$state':(store:appState),meta:(alias:'-%20Level%2012%20or%20above%20alerts',disabled:!f,index:'wazuh-alerts-*',key:query,negate:!f,type:custom,value:'%7B%22bool%22:%7B%22must%22:%5B%5D,%22filter%22:%5B%7B%22bool%22:%7B%22should%22:%5B%7B%22range%22:%7B%22rule.level%22:%7B%22gte%22:12%7D%7D%7D%5D,%22minimum_should_match%22:1%7D%7D%5D,%22should%22:%5B%5D,%22must_not%22:%5B%5D%7D%7D'),query:(bool:(filter:!((bool:(minimum_should_match:1,should:!((range:(rule.level:(gte:12))))))),must:!(),must_not:!(),should:!())))),language:kuery,query:'')&agentId=001

Safari - ⚫

Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

Test Chrome Firefox Safari
The overview must be rendered correctly 🟢
The navigation to the different modules with pinned agent should work as expected. 🟢
The navigation to the different modules with unpinned agent should work as expected. 🟢
the tab tabView _g _a and if applicable the agentId must appear in the URL. 🟢

Details

🟢 The overview must be rendered correctly

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 The navigation to the different modules with **pinned** agent should work as expected.

Chrome -🟢

pinned-agent-navigation.webm

Firefox - ⚫

Safari - ⚫

🟢 The navigation to the different modules with **unpinned** agent should work as expected.

Chrome - 🟢

unpinned-agent-navigation.webm

Firefox - ⚫

Safari - ⚫

🟢 the Tab TabView _g _a and if applicable the agentId must appear in the URL.

Chrome - 🟢

image

https://localhost:5601/app/threat-hunting#/overview/?tab=general&tabView=panels&agentId=001&_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-24h,to:now))&_a=(filters:!(('$state':(store:appState),meta:(alias:!n,controlledBy:cluster-manager,disabled:!f,index:'wazuh-alerts-*',key:cluster.name,negate:!f,params:(query:wazuh),removable:!f,type:phrase),query:(match:(cluster.name:(query:wazuh,type:phrase)))),('$state':(store:appState),meta:(alias:!n,controlledBy:pinned-agent,disabled:!f,index:'wazuh-alerts-*',key:agent.id,negate:!f,params:(query:'001'),type:phrase),query:(match:(agent.id:(query:'001',type:phrase))))),language:kuery,query:'')
Firefox - ⚫

Safari - ⚫

lucianogorza
lucianogorza previously approved these changes May 3, 2024
jbiset
jbiset previously approved these changes May 6, 2024
lucianogorza
lucianogorza previously approved these changes May 7, 2024
@yenienserrano yenienserrano dismissed stale reviews from lucianogorza and jbiset via bdf67eb May 7, 2024 13:36
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The missing changelog entry was added, I will merge it.

@Desvelao Desvelao merged commit 6fef597 into 4.9.0 May 7, 2024
1 check passed
@Desvelao Desvelao deleted the feat/6593-remove-discover-refactor-angularjs-overview-controller branch May 7, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remove discover] Refactor AngularJS overview controller
4 participants