-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove overview AngularJS controllers #6594
Remove overview AngularJS controllers #6594
Conversation
…s-overview-controller
…s-overview-controller
…s-overview-controller
…s-overview-controller
…s-overview-controller
…s-overview-controller
…s-overview-controller
…s-overview-controller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: 🟢
Test UI 🟢
Test | Chrome | Firefox | Safari |
---|---|---|---|
The overview must be rendered correctly | 🟢 | 🟢 | ⚫ |
The navigation to the different modules should work as expected and modules must render the corresponding dashboards whether or not they have a pinned agent. | 🟢 | 🟢 | ⚫ |
the tab tabView _g _a and if applicable the agentId must appear in the URL. |
🟢 | 🟢 | ⚫ |
Details
🟢 The navigation to the different modules should work as expected. And modules must render the corresponding dashboards whether or not they have a pinned agent
Chrome - 🟢
Evidence_1_Chrome.webm
Firefox - 🟢
Evidence_1_Firefox.webm
Safari - ⚫
🟢 the Tab TabView _g _a and if applicable the agentId must appear in the URL.
Chrome - 🟢
URL:
Firefox - 🟢
URL:
Safari - ⚫
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 🟢
Test 🟢
Test | Chrome | Firefox | Safari |
---|---|---|---|
The overview must be rendered correctly | 🟢 | ⚫ | ⚫ |
The navigation to the different modules with pinned agent should work as expected. | 🟢 | ⚫ | ⚫ |
The navigation to the different modules with unpinned agent should work as expected. | 🟢 | ⚫ | ⚫ |
the tab tabView _g _a and if applicable the agentId must appear in the URL. |
🟢 | ⚫ | ⚫ |
Details
🟢 The navigation to the different modules with **pinned** agent should work as expected.
Chrome -🟢
pinned-agent-navigation.webm
Firefox - ⚫
Safari - ⚫
🟢 The navigation to the different modules with **unpinned** agent should work as expected.
Chrome - 🟢
unpinned-agent-navigation.webm
Firefox - ⚫
Safari - ⚫
🟢 the Tab TabView _g _a and if applicable the agentId must appear in the URL.
Chrome - 🟢
Safari - ⚫
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The missing changelog entry was added, I will merge it.
Description
This pull request removes the overview AngularJS controllers.
Issues Resolved
Evidence
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
tab
tabView
_g
_a
and if applicable theagentId
must appear in the URL.Details
⚫ The overview must be rendered correctly
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ the navigation to the different modules should work as expected.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ the Tab TabView _g _a and if applicable the agentId must appear in the URL.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Modules must render the corresponding dashboards whether or not they have a pinned agent.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest