-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select package type to upgrade #6648
Merged
asteriscos
merged 3 commits into
4.9.0
from
enhancement/1102-select-package-type-to-upgrade
May 10, 2024
Merged
Select package type to upgrade #6648
asteriscos
merged 3 commits into
4.9.0
from
enhancement/1102-select-package-type-to-upgrade
May 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucianogorza
force-pushed
the
enhancement/1102-select-package-type-to-upgrade
branch
2 times, most recently
from
May 7, 2024 17:36
de1da83
to
8dee1b3
Compare
lucianogorza
force-pushed
the
enhancement/1102-select-package-type-to-upgrade
branch
from
May 7, 2024 20:29
8dee1b3
to
5745e21
Compare
yenienserrano
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ubuntu agent
Details 🟢 Click the `All actions` (`...`) button in the agent row and click `Upgrade`. A modal should open should only display the Agent ID, Agent name, Agent version and OS fields.🟢 Inside the modal, click `Upgrade`. The API request should only use the `agents_list` and `wait_for_complete` parameters.Alpine agent
Details 🟢 Click the `All actions` (`...`) button in the agent row and click `Upgrade`. A modal should open should display the Agent ID, Agent name, Agent version and OS fields, and the package type input. |
asteriscos
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When upgrade an individual agent, in case that the OS is
Linux
and the platform is not one of these:debian
ubuntu
amzn
centos
fedora
ol
opensuse
opensuse-leap
opensuse-tumbleweed
rhel
sles
suse
The confirm modal asks for the package type (RPM or DEB).
Note
The multiple upgrade action was not modified
Issues Resolved
https://github.com/wazuh/internal-devel-requests/issues/1102
Evidence
Ubuntu platform
The request was made without
package_type
andforce
parametersAlpine platform
The request was made with
package_type
andforce
parametersTest
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Important
Test with a real manager from this branch: https://github.com/wazuh/wazuh/tree/migration/21755-wazuh-packages-redesign. Here are the API changes with the new
package_type
parameter.Create an out of date agent with Ubuntu (or other supported Linux platform)
Create an out of date agent with Alpine (or other unsupported Linux platform)
Vagrantfile
Guide to install the agent in Alpine: https://documentation.wazuh.com/current/installation-guide/wazuh-agent/wazuh-agent-package-linux.html (APK tab)
Docker
Go to Server management -> Endpoint Summary
Ubuntu agent
All actions
(...
) button in the agent row and clickUpgrade
. A modal should open should only display the Agent ID, Agent name, Agent version and OS fields.Upgrade
. The API request should only use theagents_list
andwait_for_complete
parameters.Details
⚫ Click the `All actions` (`...`) button in the agent row and click `Upgrade`. A modal should open should only display the Agent ID, Agent name, Agent version and OS fields.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Inside the modal, click `Upgrade`. The API request should only use the `agents_list` and `wait_for_complete` parameters.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Alpine agent
All actions
(...
) button in the agent row and clickUpgrade
. A modal should open should display the Agent ID, Agent name, Agent version and OS fields, and the package type input.Upgrade
. The API request should use theagents_list
,wait_for_complete
,force
andpackage_type
parameters.Details
⚫ Click the `All actions` (`...`) button in the agent row and click `Upgrade`. A modal should open should display the Agent ID, Agent name, Agent version and OS fields, and the package type input.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Inside the modal, select the package type and click `Upgrade`. The API request should use the `agents_list`, `wait_for_complete`, `force` and `package_type` parameters.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest