-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cluster configuration with the haproxy helper settings #6653
Merged
asteriscos
merged 10 commits into
4.9.0
from
175-update-the-dashboard-panel-where-haproxy-helper-configuration-is-shown
May 14, 2024
Merged
Update Cluster configuration with the haproxy helper settings #6653
asteriscos
merged 10 commits into
4.9.0
from
175-update-the-dashboard-panel-where-haproxy-helper-configuration-is-shown
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-helper-configuration-is-shown
UI
Details 🟢 Without the `haproxy_handler` configuration, only the main settings should be rendered.Chrome - 🟢 Firefox - 🟢 Safari - ⚫ 🟢 With the basic `haproxy_handler` configuration, everything should render with the default valuesChrome - 🟢 Firefox - 🟢 Safari - ⚫ 🟢 By adding the other settings, the changed settings should render.Chrome - 🟢 Firefox - 🟢 Safari - ⚫ These configurations go inside |
JuanGarriuz
previously approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
Desvelao
reviewed
May 14, 2024
...ns/main/public/controllers/management/components/management/configuration/cluster/cluster.js
Show resolved
Hide resolved
Desvelao
reviewed
May 14, 2024
...ns/main/public/controllers/management/components/management/configuration/cluster/cluster.js
Show resolved
Hide resolved
🟡 Missing changelog UI
Details 🟢 Without the `haproxy_handler` configuration, only the main settings should be rendered.Chrome - 🟢 Firefox - 🟢 🟢 With the basic `haproxy_handler` configuration, everything should render with the default valuesChrome - 🟢 Firefox - 🟢 These configurations go inside |
asteriscos
previously approved these changes
May 14, 2024
asteriscos
approved these changes
May 14, 2024
asteriscos
deleted the
175-update-the-dashboard-panel-where-haproxy-helper-configuration-is-shown
branch
May 14, 2024 15:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Cluster configuration with the haproxy helper settings
Issues Resolved
HAProxy helper
configuration is shown wazuh-dashboard#175Evidence
Test
You can try the imposter or a manager of this branch: epic-20887-migrate-haproxy-helper
If you use a manager on that branch you will have to run this so that the manager doesn't hang. And then restart wazuh
/var/ossec/framework/python/bin/pip3 install httpx
Tests:
Always in
Server Management/Settings/Cluster
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
haproxy_handler
configuration, only the main settings should be rendered.haproxy_handler
configuration, everything should render with the default valuesDetails
⚫ Without the `haproxy_handler` configuration, only the main settings should be rendered.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ With the basic `haproxy_handler` configuration, everything should render with the default values
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ By adding the other settings, the changed settings should render.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
These configurations go inside
<cluster></cluster>
Basic settings:
All settings:
Check List
yarn test:jest