-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitize uploaded SVG files #6687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desvelao
reviewed
May 20, 2024
plugins/main/server/start/sanitize-uploaded-files/sanitize-svg.ts
Outdated
Show resolved
Hide resolved
Desvelao
reviewed
May 20, 2024
plugins/main/server/start/sanitize-uploaded-files/sanitize-svg.ts
Outdated
Show resolved
Hide resolved
Desvelao
reviewed
May 20, 2024
Test
|
jbiset
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: 🟢
Test: 🟢
Upload file 🟢
- Go to Settings / Configuration
- Upload the provided test SVG file
- Verify the script embedded is removed
Sanitize previously uploaded files 🟢
- Save the sample SVG file into the custom branding images folder
- Initialize the app
- Verify the script has been removed
Machi3mfl
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: ✅
Test: ✅
Removes script tag from svg file when is uploaded via UI
Screen.Recording.2024-05-21.at.15.49.05.mov
Adding script tag inside svg file when the file is already uploaded
The svg file is cleaned after execute the cron job
Screen.Recording.2024-05-21.at.15.49.45.mov
Screen.Recording.2024-05-21.at.15.51.24.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds sanitization to uploaded SVG custom branding files.
Evidence
Test
Upload file
Sanitize previously uploaded files
Sample SVG file
customization.logo.app.svg
Check List
yarn test:jest