Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cannot perform a react state update on an unmounted component #6704

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented May 23, 2024

Description

Fix cannot perform a React state update on an unmounted component in the framework tab of the MITRE ATT&CK module, in the inventory data and stats tabs of the endpoint summary module.

Issues Resolved

#6693

Evidence

image image image image

Test

  • Go to the Framework tab of the MITRE ATT&CK module and verify that there is no warning in the console with the message Can't perform a React state update on an unmounted component.
  • Go to the Endpoint summary module, select an agent then select inventory data and check that there is no warning in the console with the message Can't perform a React state update on an unmounted component.
  • Go to the Endpoint summary module, select an agent then select stats and check that there is no warning in the console with the message Can't perform a React state update on an unmounted component.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm self-assigned this May 23, 2024
@chantal-kelm chantal-kelm linked an issue May 23, 2024 that may be closed by this pull request
15 tasks
@chantal-kelm chantal-kelm mentioned this pull request May 23, 2024
15 tasks
@chantal-kelm chantal-kelm marked this pull request as ready for review May 28, 2024 19:25
@chantal-kelm chantal-kelm changed the title Fix/6693 cannot perform a react state update on an unmounted component Fix cannot perform a react state update on an unmounted component May 28, 2024
@yenienserrano yenienserrano self-requested a review May 30, 2024 15:09
@yenienserrano
Copy link
Member

yenienserrano commented May 30, 2024

  • Go to the Framework tab of the MITRE ATT&CK module and verify that there is no warning in the console with the message Can't perform a React state update on an unmounted component.
Details
Screen.Recording.2024-05-30.at.5.17.58.PM.mov
  • Go to the Endpoint summary module, select an agent then select inventory data and check that there is no warning in the console with the message Can't perform a React state update on an unmounted component.
Details
  • Go to the Endpoint summary module, select an agent then select stats and check that there is no warning in the console with the message Can't perform a React state update on an unmounted component.
Details

@yenienserrano yenienserrano removed their request for review May 30, 2024 15:21
@chantal-kelm chantal-kelm marked this pull request as draft May 30, 2024 15:25
@chantal-kelm
Copy link
Member Author

chantal-kelm commented May 30, 2024

IMPORTANT

It was decided to postpone this PR in order to build a common solution for all components.

@chantal-kelm chantal-kelm force-pushed the fix/6693-cannot-perform-a-react-state-update-on-an-unmounted-component branch from c47fda0 to 08b0da5 Compare June 3, 2024 17:10
@chantal-kelm chantal-kelm linked an issue Jun 3, 2024 that may be closed by this pull request
4 tasks
@chantal-kelm
Copy link
Member Author

chantal-kelm commented Jun 6, 2024

IMPORTANT

This PR is still in progress, we will postpone it to the next stage.

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

@juliamagan juliamagan deleted the branch 4.9.0 September 12, 2024 09:50
@juliamagan juliamagan closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: Can't perform a React state update on an unmounted component. Warnings and errors in console
3 participants