Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space to macOS command with password #6718

Merged

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented May 29, 2024

Description

Hi team,
this pull request adds a space to the macOS agent register command when a password is required. Also, it adds a gap after the Show password switch to create a space before the info callout.

Note

This PR applies a fix that was planned for 4.8.0
#6305

Issues Resolved

Closes #6717

Evidence

curl -so wazuh-agent.pkg https://packages.wazuh.com/4.x/macos/wazuh-agent-4.7.5-1.arm64.pkg && echo "WAZUH_MANAGER='1.1.1.1' && WAZUH_AGENT_GROUP='default,test-group' && WAZUH_AGENT_NAME='new-agent' && WAZUH_REGISTRATION_PASSWORD='Password123'\n" > /tmp/wazuh_envs && sudo installer -pkg ./wazuh-agent.pkg -target /
Screenshot

screencapture-localhost-5601-app-wazuh-2024-05-29-14_34_48

Test

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this May 29, 2024
@asteriscos asteriscos linked an issue May 29, 2024 that may be closed by this pull request
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

curl -so wazuh-agent.pkg https://packages.wazuh.com/4.x/macos/wazuh-agent-4.7.4-1.arm64.pkg && echo "WAZUH_MANAGER='1.1.1.1' && WAZUH_AGENT_GROUP='default,test-group' && WAZUH_AGENT_NAME='new-agent' && WAZUH_REGISTRATION_PASSWORD='Password123'\n" > /tmp/wazuh_envs && sudo installer -pkg ./wazuh-agent.pkg -target /
image

@asteriscos asteriscos merged commit c3aff71 into 4.7.5 May 29, 2024
1 check passed
@asteriscos asteriscos deleted the fix/6717-add-space-to-macOS-register-command-with-password branch May 29, 2024 12:37
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test UI 🟢

Evidence

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Register agent macOS command with password doesn't work
3 participants