Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cronjob max seconds interval #6730

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented May 30, 2024

Description

This pull request fixes the maximum allowed seconds validation of the cronjobs configuration.
The correct value is 24 * 3600 = 86400

Issues Resolved

Closes #6688

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this May 30, 2024
@asteriscos asteriscos linked an issue May 30, 2024 that may be closed by this pull request
Copy link
Member

@gdiazlo gdiazlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@asteriscos asteriscos merged commit 8d87fe2 into 4.9.0 May 30, 2024
1 check passed
@asteriscos asteriscos deleted the fix/6688-fix-cronjob-max-seconds branch May 30, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect number of seconds in a day
2 participants