-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix styles in small height viewports #6747
Fix styles in small height viewports #6747
Conversation
Test
DetailsI don't know if I understood the issue correctly but maybe you also want to remove the scroll inside the table so that the page only has the scroll. Screen.Recording.2024-06-06.at.3.56.41.PM.mov
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: In Progress - Comment added
Test UI 🔴
Check that inventory tabs around the app are rendered correctly (The tab selector doesn't must stay on the top of view) 🔴
There is a difference between table scrolling in Chrome and Firefox. In Chrome the table does not have a scrollbar and grows by the size of the table. On the other hand, in Firefox the table does not grow and a scroolbar appears for the body of the table.
- Chrome
Evidence_1_Chrome.webm
- Firefox
Evidence_1_Firefox.webm
Check full screen in the inventory tab table works as expected. 🟢
- Chrome
Evidence_2_Chrome.webm
- Firefox
Evidence_2_Firefox.webm
|
|
|
TestData grid
DetailsScreen.Recording.2024-06-07.at.9.25.25.PM.movControls flyout details
Fix date format with pinned agent in Mitre att&ck -> Framework flyout
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: 🟢
Test UI 🟢
Check that inventory tabs around the app are rendered correctly (The tab selector doesn't must stay on the top of view) 🟢
- Chrome
Evidence_1_Chrome_ok.webm
- Firefox
Evidence_1_Firefox_ok.webm
Check full screen in the inventory tab table works as expected. 🟢
- Chrome
Evidence_2_Chrome.webm
- Firefox
Evidence_2_Firefox.webm
Check Threat intelligence > Threat Hunting > dashboard view render correctly 🟢
- Chrome
Evidence_3_Chrome_ok.webm
- Firefox
Evidence_3_Firefox_ok.webm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Issues Resolved
Evidence
Grabacion.2024-06-05.130411.mp4
Test
Data grid
Controls flyout details
Fix date format with pinned agent in Mitre att&ck -> Framework flyout
Check List
yarn test:jest