Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced SearchBar with WzSearchBar in flyout component #6755

Conversation

jbiset
Copy link
Member

@jbiset jbiset commented Jun 11, 2024

Description

This PR replaces SearchBar with WzSearchBar in flyout component. Also, add an attribute (hideFixedFilters) to WzSearchBar so that it hides the fixed filters if necessary.

Issues Resolved

Evidence

Inventory FIM Flyout

image

Dashboard FIM

image

Test

  • Check Flyout
    • Go to some screen that uses SearchBar in the flyout, for example, Inventory FIM.
    • Make the necessary interaction to open the Flyout.
    • Check that the SearchBar does not show the filters set as shown in the evidence.
  • Check SearchBar on non-Flyout screens
    • Go to a screen that uses the SearchBar other than Flyout
    • Check, if applicable, that it shows the set filters.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@jbiset jbiset self-assigned this Jun 11, 2024
@jbiset jbiset linked an issue Jun 11, 2024 that may be closed by this pull request
25 tasks
@lucianogorza lucianogorza self-requested a review June 11, 2024 14:55
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 11.37% ( 3898 / 34261 )
Branches 7.62% ( 1721 / 22562 )
Functions 10.67% ( 895 / 8385 )
Lines 11.53% ( 3795 / 32894 )

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

image

@lucianogorza lucianogorza merged commit 4907d4f into 4.9.0 Jun 11, 2024
4 checks passed
@lucianogorza lucianogorza deleted the change/replace-searchbar-with-wzsearchbar-in-flyout-component branch June 11, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Wazuh Searchbar component
3 participants